diff options
| author |  kkinnunen <kkinnunen@nvidia.com> | 2015-11-22 23:23:53 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-11-22 23:23:53 -0800 |
| commit | 5931922997b8904b1243240120014c016064b9fa (patch) | |
| tree | c0f3e55685dd5e6f50665f9e7a4421bccde3e310 /tests/GrContextFactoryTest.cpp | |
| parent | 7ea33f5e1ae9eb1fb1e7377d6edf6acdcf71d103 (diff) | |
Remove GrContextFactory::getGLContext
Remove GrContextFactory::getGLContext, it is problematic:
It has the bug of not checking for the context type.
It also is error-prone, since the GL context is not made
current, but it is callers may assume it is current.
It is also not used very much.
Clients can use GrContextFactory::getContextInfo.
BUG=skia:
Review URL: https://codereview.chromium.org/1455093003
Diffstat (limited to 'tests/GrContextFactoryTest.cpp')
| -rw-r--r-- | tests/GrContextFactoryTest.cpp | 19 |
1 files changed, 1 insertions, 18 deletions
diff --git a/tests/GrContextFactoryTest.cpp b/tests/GrContextFactoryTest.cpp index 787f16c983..79209c719f 100644 --- a/tests/GrContextFactoryTest.cpp +++ b/tests/GrContextFactoryTest.cpp @@ -12,23 +12,6 @@ #include "GrContextFactory.h" #include "Test.h" -DEF_GPUTEST(GrContextFactory, reporter, factory) { - // Reset in case some other test has been using it first. - factory->destroyContexts(); - - // Before we ask for a context, we expect the GL context to not be there. - REPORTER_ASSERT(reporter, - nullptr == factory->getGLContext(GrContextFactory::kNull_GLContextType)); - - // After we ask for a context, we expect that the GL context to be there. - factory->get(GrContextFactory::kNull_GLContextType); - REPORTER_ASSERT(reporter, - factory->getGLContext(GrContextFactory::kNull_GLContextType) != nullptr); - - // If we did not ask for a context with the particular GL context, we would - // expect the particular GL context to not be there. - REPORTER_ASSERT(reporter, - nullptr == factory->getGLContext(GrContextFactory::kDebug_GLContextType)); -} +// TODO: test GrContextFactory. #endif |