diff options
author | 2016-02-24 08:19:04 -0800 | |
---|---|---|
committer | 2016-02-24 08:19:04 -0800 | |
commit | f15b07b75ce6b1ad2bde91b3baf17ef9210241b3 (patch) | |
tree | 825b9ab8ea5c7400fbdce873d9aeccaa17ab0690 /src | |
parent | 8516dc10161ebdfdffe6fe6f90b3d1b9adc429bc (diff) |
Revert of Include glGetMultisamplefv API (patchset #1 id:1 of https://codereview.chromium.org/1720963002/ )
Reason for revert:
This is in the blamelist for Visualbench failures:
https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-VisualBench/builds/1035
and seems the most likely candidate for the failure, so I am tentatively reverting.
Original issue's description:
> Include glGetMultisamplefv API
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002
>
> Committed: https://skia.googlesource.com/skia/+/69c1b24bcaa7cffd59753a75a7f3d155696fcac4
TBR=bsalomon@google.com,joshualitt@google.com,cdalton@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1731333002
Diffstat (limited to 'src')
-rw-r--r-- | src/gpu/GrCaps.cpp | 2 | ||||
-rw-r--r-- | src/gpu/gl/GrGLAssembleInterface.cpp | 8 | ||||
-rw-r--r-- | src/gpu/gl/GrGLCaps.cpp | 7 | ||||
-rw-r--r-- | src/gpu/gl/GrGLCreateNullInterface.cpp | 1 | ||||
-rw-r--r-- | src/gpu/gl/GrGLDefines.h | 1 | ||||
-rw-r--r-- | src/gpu/gl/GrGLInterface.cpp | 8 | ||||
-rw-r--r-- | src/gpu/gl/GrGLNoOpInterface.cpp | 6 | ||||
-rw-r--r-- | src/gpu/gl/GrGLNoOpInterface.h | 2 | ||||
-rw-r--r-- | src/gpu/gl/SkNullGLContext.cpp | 1 | ||||
-rw-r--r-- | src/gpu/gl/debug/GrGLCreateDebugInterface.cpp | 1 |
10 files changed, 0 insertions, 37 deletions
diff --git a/src/gpu/GrCaps.cpp b/src/gpu/GrCaps.cpp index c544d6ef77..4fb05c14a1 100644 --- a/src/gpu/GrCaps.cpp +++ b/src/gpu/GrCaps.cpp @@ -92,7 +92,6 @@ GrCaps::GrCaps(const GrContextOptions& options) { fCompressedTexSubImageSupport = false; fOversizedStencilSupport = false; fTextureBarrierSupport = false; - fSampleLocationsSupport = false; fUsesMixedSamples = false; fSupportsInstancedDraws = false; fFullClearIsFree = false; @@ -166,7 +165,6 @@ SkString GrCaps::dump() const { r.appendf("Compressed Update Support : %s\n", gNY[fCompressedTexSubImageSupport]); r.appendf("Oversized Stencil Support : %s\n", gNY[fOversizedStencilSupport]); r.appendf("Texture Barrier Support : %s\n", gNY[fTextureBarrierSupport]); - r.appendf("Sample Locations Support : %s\n", gNY[fSampleLocationsSupport]); r.appendf("Uses Mixed Samples : %s\n", gNY[fUsesMixedSamples]); r.appendf("Supports instanced draws : %s\n", gNY[fSupportsInstancedDraws]); r.appendf("Full screen clear is free : %s\n", gNY[fFullClearIsFree]); diff --git a/src/gpu/gl/GrGLAssembleInterface.cpp b/src/gpu/gl/GrGLAssembleInterface.cpp index f23bf17d69..e52d302190 100644 --- a/src/gpu/gl/GrGLAssembleInterface.cpp +++ b/src/gpu/gl/GrGLAssembleInterface.cpp @@ -162,9 +162,6 @@ const GrGLInterface* GrGLAssembleGLInterface(void* ctx, GrGLGetProc get) { GET_PROC(GetBufferParameteriv); GET_PROC(GetError); GET_PROC(GetIntegerv); - if (glVer >= GR_GL_VER(3,2)) { - GET_PROC(GetMultisamplefv); - } GET_PROC(GetQueryObjectiv); GET_PROC(GetQueryObjectuiv); if (glVer >= GR_GL_VER(3,3) || extensions.has("GL_ARB_timer_query")) { @@ -612,11 +609,6 @@ const GrGLInterface* GrGLAssembleGLESInterface(void* ctx, GrGLGetProc get) { GET_PROC(GetBufferParameteriv); GET_PROC(GetError); GET_PROC(GetIntegerv); - - if (version >= GR_GL_VER(3,1)) { - GET_PROC(GetMultisamplefv); - } - GET_PROC(GetProgramInfoLog); GET_PROC(GetProgramiv); GET_PROC(GetShaderInfoLog); diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp index 883ac15251..546b0bf692 100644 --- a/src/gpu/gl/GrGLCaps.cpp +++ b/src/gpu/gl/GrGLCaps.cpp @@ -126,13 +126,6 @@ void GrGLCaps::init(const GrContextOptions& contextOptions, fTextureBarrierSupport = ctxInfo.hasExtension("GL_NV_texture_barrier"); } - if (kGL_GrGLStandard == standard) { - fSampleLocationsSupport = version >= GR_GL_VER(3,2) || - ctxInfo.hasExtension("GL_ARB_texture_multisample"); - } else { - fSampleLocationsSupport = version >= GR_GL_VER(3,1); - } - // ARB_texture_rg is part of OpenGL 3.0, but mesa doesn't support GL_RED // and GL_RG on FBO textures. if (kMesa_GrGLDriver != ctxInfo.driver()) { diff --git a/src/gpu/gl/GrGLCreateNullInterface.cpp b/src/gpu/gl/GrGLCreateNullInterface.cpp index 17f305b6e3..f56b1d9773 100644 --- a/src/gpu/gl/GrGLCreateNullInterface.cpp +++ b/src/gpu/gl/GrGLCreateNullInterface.cpp @@ -402,7 +402,6 @@ const GrGLInterface* GrGLCreateNullInterface() { functions->fGetBufferParameteriv = nullGLGetBufferParameteriv; functions->fGetError = noOpGLGetError; functions->fGetIntegerv = noOpGLGetIntegerv; - functions->fGetMultisamplefv = noOpGLGetMultisamplefv; functions->fGetQueryObjecti64v = noOpGLGetQueryObjecti64v; functions->fGetQueryObjectiv = noOpGLGetQueryObjectiv; functions->fGetQueryObjectui64v = noOpGLGetQueryObjectui64v; diff --git a/src/gpu/gl/GrGLDefines.h b/src/gpu/gl/GrGLDefines.h index 219501c1f8..9be769fb85 100644 --- a/src/gpu/gl/GrGLDefines.h +++ b/src/gpu/gl/GrGLDefines.h @@ -382,7 +382,6 @@ /* multisample */ #define GR_GL_MULTISAMPLE 0x809D -#define GR_GL_SAMPLE_POSITION 0x8E50 /* Points */ #define GR_GL_POINT_SMOOTH 0x0B10 diff --git a/src/gpu/gl/GrGLInterface.cpp b/src/gpu/gl/GrGLInterface.cpp index 84c51fb252..c09efae2b8 100644 --- a/src/gpu/gl/GrGLInterface.cpp +++ b/src/gpu/gl/GrGLInterface.cpp @@ -487,14 +487,6 @@ bool GrGLInterface::validate() const { } if ((kGL_GrGLStandard == fStandard && - (glVer >= GR_GL_VER(3,2) || fExtensions.has("GL_ARB_texture_multisample"))) || - (kGLES_GrGLStandard == fStandard && glVer >= GR_GL_VER(3,1))) { - if (NULL == fFunctions.fGetMultisamplefv) { - RETURN_FALSE_INTERFACE - } - } - - if ((kGL_GrGLStandard == fStandard && (glVer >= GR_GL_VER(4,3) || fExtensions.has("GL_ARB_program_interface_query"))) || (kGLES_GrGLStandard == fStandard && glVer >= GR_GL_VER(3,1))) { if (nullptr == fFunctions.fGetProgramResourceLocation) { diff --git a/src/gpu/gl/GrGLNoOpInterface.cpp b/src/gpu/gl/GrGLNoOpInterface.cpp index 3cf9ecd1e2..f08d737d58 100644 --- a/src/gpu/gl/GrGLNoOpInterface.cpp +++ b/src/gpu/gl/GrGLNoOpInterface.cpp @@ -561,12 +561,6 @@ GrGLvoid GR_GL_FUNCTION_TYPE noOpGLGetInfoLog(GrGLuint program, } } -GrGLvoid GR_GL_FUNCTION_TYPE noOpGLGetMultisamplefv(GrGLenum pname, - GrGLuint index, - GrGLfloat* val) { - val[0] = val[1] = 0.5f; -} - GrGLvoid GR_GL_FUNCTION_TYPE noOpGLGetShaderOrProgramiv(GrGLuint program, GrGLenum pname, GrGLint* params) { diff --git a/src/gpu/gl/GrGLNoOpInterface.h b/src/gpu/gl/GrGLNoOpInterface.h index 23168e28a3..44894b763a 100644 --- a/src/gpu/gl/GrGLNoOpInterface.h +++ b/src/gpu/gl/GrGLNoOpInterface.h @@ -363,8 +363,6 @@ GrGLvoid GR_GL_FUNCTION_TYPE noOpGLGetInfoLog(GrGLuint program, GrGLsizei* length, char* infolog); -GrGLvoid GR_GL_FUNCTION_TYPE noOpGLGetMultisamplefv(GrGLenum pname, GrGLuint index, GrGLfloat* val); - // can be used for both the program and shader params GrGLvoid GR_GL_FUNCTION_TYPE noOpGLGetShaderOrProgramiv(GrGLuint program, GrGLenum pname, diff --git a/src/gpu/gl/SkNullGLContext.cpp b/src/gpu/gl/SkNullGLContext.cpp index 33f9a0a0a0..68b19ce990 100644 --- a/src/gpu/gl/SkNullGLContext.cpp +++ b/src/gpu/gl/SkNullGLContext.cpp @@ -451,7 +451,6 @@ static GrGLInterface* create_null_interface(State* state) { functions->fGetBufferParameteriv = nullGLGetBufferParameteriv; functions->fGetError = noOpGLGetError; functions->fGetIntegerv = noOpGLGetIntegerv; - functions->fGetMultisamplefv = noOpGLGetMultisamplefv; functions->fGetQueryObjecti64v = noOpGLGetQueryObjecti64v; functions->fGetQueryObjectiv = noOpGLGetQueryObjectiv; functions->fGetQueryObjectui64v = noOpGLGetQueryObjectui64v; diff --git a/src/gpu/gl/debug/GrGLCreateDebugInterface.cpp b/src/gpu/gl/debug/GrGLCreateDebugInterface.cpp index 23e0d7e919..2118c02fa7 100644 --- a/src/gpu/gl/debug/GrGLCreateDebugInterface.cpp +++ b/src/gpu/gl/debug/GrGLCreateDebugInterface.cpp @@ -895,7 +895,6 @@ const GrGLInterface* GrGLCreateDebugInterface() { functions->fGetBufferParameteriv = debugGLGetBufferParameteriv; functions->fGetError = noOpGLGetError; functions->fGetIntegerv = noOpGLGetIntegerv; - functions->fGetMultisamplefv = noOpGLGetMultisamplefv; functions->fGetQueryObjecti64v = noOpGLGetQueryObjecti64v; functions->fGetQueryObjectiv = noOpGLGetQueryObjectiv; functions->fGetQueryObjectui64v = noOpGLGetQueryObjectui64v; |