diff options
author | Greg Daniel <egdaniel@google.com> | 2018-04-02 10:52:29 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-04-02 15:37:25 +0000 |
commit | e037d7611fd6ca528059f730193f7447b4423e80 (patch) | |
tree | 170d02e20591b8ab20bd2cec77c20806b9efa9c2 /src | |
parent | 3070926579a6da7a9bcdef9ed9b85af15c9bd1c9 (diff) |
Remove specVersion check on vk extensions.
Unlike the specVersion parameter on the layers, specVersion on extensions
does not mean what vulkan spec version the extensions work with but just
what version of the extension it is. Thus we don't want to compare it
to the version of the spec we are making.
Bug: skia:
Change-Id: If47c249b4cca0b9a10bfb3b8ce88db6bda1e12ed
Reviewed-on: https://skia-review.googlesource.com/117634
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/gpu/vk/GrVkExtensions.cpp | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/src/gpu/vk/GrVkExtensions.cpp b/src/gpu/vk/GrVkExtensions.cpp index 1fe6515d86..e4768d95c9 100644 --- a/src/gpu/vk/GrVkExtensions.cpp +++ b/src/gpu/vk/GrVkExtensions.cpp @@ -89,9 +89,7 @@ bool GrVkExtensions::initInstance(uint32_t specVersion) { return false; } for (uint32_t i = 0; i < extensionCount; ++i) { - if (nonPatchVersion <= remove_patch_version(extensions[i].specVersion)) { - fInstanceExtensionStrings->push_back() = extensions[i].extensionName; - } + fInstanceExtensionStrings->push_back() = extensions[i].extensionName; } delete [] extensions; // sort so we can search @@ -116,8 +114,7 @@ bool GrVkExtensions::initInstance(uint32_t specVersion) { } for (uint32_t i = 0; i < extensionCount; ++i) { // if not already in the list, add it - if (nonPatchVersion <= remove_patch_version(extensions[i].specVersion) && - find_string(*fInstanceExtensionStrings, extensions[i].extensionName) < 0) { + if (find_string(*fInstanceExtensionStrings, extensions[i].extensionName) < 0) { fInstanceExtensionStrings->push_back() = extensions[i].extensionName; SkTQSort(&fInstanceExtensionStrings->front(), &fInstanceExtensionStrings->back(), cmp); @@ -183,9 +180,7 @@ bool GrVkExtensions::initDevice(uint32_t specVersion, VkInstance inst, VkPhysica return false; } for (uint32_t i = 0; i < extensionCount; ++i) { - if (nonPatchVersion <= remove_patch_version(extensions[i].specVersion)) { - fDeviceExtensionStrings->push_back() = extensions[i].extensionName; - } + fDeviceExtensionStrings->push_back() = extensions[i].extensionName; } delete[] extensions; if (!fDeviceExtensionStrings->empty()) { @@ -212,8 +207,7 @@ bool GrVkExtensions::initDevice(uint32_t specVersion, VkInstance inst, VkPhysica } for (uint32_t i = 0; i < extensionCount; ++i) { // if not already in the list, add it - if (nonPatchVersion <= remove_patch_version(extensions[i].specVersion) && - find_string(*fDeviceExtensionStrings, extensions[i].extensionName) < 0) { + if (find_string(*fDeviceExtensionStrings, extensions[i].extensionName) < 0) { fDeviceExtensionStrings->push_back() = extensions[i].extensionName; SkTQSort(&fDeviceExtensionStrings->front(), &fDeviceExtensionStrings->back(), cmp); } |