diff options
author | mtklein <mtklein@chromium.org> | 2015-01-22 13:50:35 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-01-22 13:50:35 -0800 |
commit | cada95ad9b8e6be9bdffe1a70968a2102cc3f09d (patch) | |
tree | f217e27014c646cd5d534d3ccfb7b9d11e018fdc /src | |
parent | 5c05a1b1375301e02ecc3bf2bb5c1b851239bb5c (diff) |
Move FP texture test buffers to heap.
This is a speculative fix for the crashing N5 bots. It looks like the bots are
always failing in or around FloatingPointTextureTest.
It looks like sometimes they're hitting a SIGBUS, which I suspect is stack
overflow. FloatingPointTextureTest allocates ~320K on the stack, which may
be too much. This CL moves those buffers to the heap. For consistency I did
the same with the half-float tests, though they're only using ~1/8th the stack.
It looks like sometimes the bots are failing to malloc. I don't understand that,
and this CL doesn't address that directly. But it's possible this is still a stack
overflow, just trashing RAM and causing arbitrary mayhem instead of a SIGBUS.
I have no idea why this is a problem only on the N5. I have been unable to
reproduce this locally, neither with a K N5 nor an L N5, but the bots are pretty
reliable.
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/871623002
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions