aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorGravatar Mike Reed <reed@google.com>2018-05-21 16:50:01 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-05-21 21:11:44 +0000
commitbc721ba4be626e3ba753f55341a7019d98044102 (patch)
tree2271839219aa876383e37f5a264a9df18d645965 /src
parent18934c653fd6f31fd464dc7db83d583c864884dc (diff)
remove fragile hack in addOval to avoid computing bounds
Bug: skia: Change-Id: Ide917f54633370f1fce46a115fa923794b981e2e Reviewed-on: https://skia-review.googlesource.com/129461 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/core/SkPath.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/core/SkPath.cpp b/src/core/SkPath.cpp
index 510efd6d9d..7a0f82800c 100644
--- a/src/core/SkPath.cpp
+++ b/src/core/SkPath.cpp
@@ -1252,7 +1252,9 @@ void SkPath::addOval(const SkRect &oval, Direction dir, unsigned startPointIndex
}
SkAutoDisableDirectionCheck addc(this);
- SkAutoPathBoundsUpdate apbu(this, oval);
+ // unlike addRect(), we can't use SkAutoPathBoundsUpdate here, since even with a finite
+ // bounds, we might (due to an overflow in intermediate calculations) create a nonfinite
+ // path.
SkDEBUGCODE(int initialVerbCount = this->countVerbs());
const int kVerbs = 6; // moveTo + 4x conicTo + close