aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
diff options
context:
space:
mode:
authorGravatar Mike Klein <mtklein@chromium.org>2017-06-06 19:25:56 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2017-06-07 13:45:10 +0000
commitb15ef6f149232c93303c691b22c9bf368b1043f2 (patch)
tree724150fe9a4764f63708cfd0144ae53fecb0a0dd /src
parent4ed5dac522f66bbe13ed10548dc57a8138234356 (diff)
we can std::move work to avoid copying it
clang-tidy pointed out this opportunity in the Google3 build. Change-Id: Id3c7b291fec12cbf860e7fc2583c1a34ad23f697 Reviewed-on: https://skia-review.googlesource.com/18927 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'src')
-rw-r--r--src/core/SkThreadedBMPDevice.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/core/SkThreadedBMPDevice.cpp b/src/core/SkThreadedBMPDevice.cpp
index 0e45b9fbf6..f5060b9556 100644
--- a/src/core/SkThreadedBMPDevice.cpp
+++ b/src/core/SkThreadedBMPDevice.cpp
@@ -20,7 +20,7 @@ constexpr int MAX_CACHE_LINE = 64;
class TiledDrawSchedulerBase : public TiledDrawScheduler {
public:
TiledDrawSchedulerBase(int tiles, WorkFunc work)
- : fTileCnt(tiles), fIsFinishing(false), fDrawCnt(0), fWork(work) {}
+ : fTileCnt(tiles), fIsFinishing(false), fDrawCnt(0), fWork(std::move(work)) {}
void signal() override {
fDrawCnt++;
@@ -39,7 +39,7 @@ protected:
class TiledDrawSchedulerBySpinning : public TiledDrawSchedulerBase {
public:
TiledDrawSchedulerBySpinning(int tiles, WorkFunc work)
- : TiledDrawSchedulerBase(tiles, work), fScheduleData(tiles) {}
+ : TiledDrawSchedulerBase(tiles, std::move(work)), fScheduleData(tiles) {}
void signal() final { this->TiledDrawSchedulerBase::signal(); }
void finish() final { this->TiledDrawSchedulerBase::finish(); }
@@ -72,7 +72,7 @@ private:
class TiledDrawSchedulerFlexible : public TiledDrawSchedulerBase {
public:
TiledDrawSchedulerFlexible(int tiles, WorkFunc work)
- : TiledDrawSchedulerBase(tiles, work), fScheduleData(tiles) {}
+ : TiledDrawSchedulerBase(tiles, std::move(work)), fScheduleData(tiles) {}
void signal() final { this->TiledDrawSchedulerBase::signal(); }
void finish() final { this->TiledDrawSchedulerBase::finish(); }
@@ -120,7 +120,7 @@ private:
class TiledDrawSchedulerBySemaphores : public TiledDrawSchedulerBase {
public:
TiledDrawSchedulerBySemaphores(int tiles, WorkFunc work)
- : TiledDrawSchedulerBase(tiles, work), fScheduleData(tiles) {}
+ : TiledDrawSchedulerBase(tiles, std::move(work)), fScheduleData(tiles) {}
void signal() final {