diff options
author | 2016-05-16 09:14:53 -0700 | |
---|---|---|
committer | 2016-05-16 09:14:53 -0700 | |
commit | 7761d61876ea479dd9672b684fd5c7601932a767 (patch) | |
tree | 72921edb7fb7083a78f3eff0f5fe61e4de409d33 /src | |
parent | d584d46c9943c641e0111b969b400be06351a949 (diff) |
Rename GrDrawingMgr::abandon to wasAbandoned & add a matching entry point to GrDrawingContext
Since GrDrawingContext is generally replacing GrRenderTarget, this is to provide functionality similar to GrRenderTarget::wasDestroyed.
This is split out of https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1979913002
Review-Url: https://codereview.chromium.org/1979913002
Diffstat (limited to 'src')
-rw-r--r-- | src/gpu/GrContext.cpp | 8 | ||||
-rw-r--r-- | src/gpu/GrDrawContext.cpp | 12 | ||||
-rw-r--r-- | src/gpu/GrDrawingManager.cpp | 4 | ||||
-rw-r--r-- | src/gpu/GrDrawingManager.h | 2 | ||||
-rw-r--r-- | src/gpu/GrPathRenderingDrawContext.cpp | 2 |
5 files changed, 16 insertions, 12 deletions
diff --git a/src/gpu/GrContext.cpp b/src/gpu/GrContext.cpp index 39916b9728..9f5d7bde0b 100644 --- a/src/gpu/GrContext.cpp +++ b/src/gpu/GrContext.cpp @@ -26,9 +26,9 @@ #define ASSERT_OWNED_RESOURCE(R) SkASSERT(!(R) || (R)->getContext() == this) #define ASSERT_SINGLE_OWNER \ SkDEBUGCODE(GrSingleOwner::AutoEnforce debug_SingleOwner(&fSingleOwner);) -#define RETURN_IF_ABANDONED if (fDrawingManager->abandoned()) { return; } -#define RETURN_FALSE_IF_ABANDONED if (fDrawingManager->abandoned()) { return false; } -#define RETURN_NULL_IF_ABANDONED if (fDrawingManager->abandoned()) { return nullptr; } +#define RETURN_IF_ABANDONED if (fDrawingManager->wasAbandoned()) { return; } +#define RETURN_FALSE_IF_ABANDONED if (fDrawingManager->wasAbandoned()) { return false; } +#define RETURN_NULL_IF_ABANDONED if (fDrawingManager->wasAbandoned()) { return nullptr; } //////////////////////////////////////////////////////////////////////////////// @@ -686,7 +686,7 @@ sk_sp<GrDrawContext> GrContext::newDrawContext(SkBackingFit fit, bool GrContext::abandoned() const { ASSERT_SINGLE_OWNER - return fDrawingManager->abandoned(); + return fDrawingManager->wasAbandoned(); } namespace { diff --git a/src/gpu/GrDrawContext.cpp b/src/gpu/GrDrawContext.cpp index 549e5ebf80..108f3a2280 100644 --- a/src/gpu/GrDrawContext.cpp +++ b/src/gpu/GrDrawContext.cpp @@ -35,10 +35,10 @@ SkDEBUGCODE(GrSingleOwner::AutoEnforce debug_SingleOwner(fSingleOwner);) #define ASSERT_SINGLE_OWNER_PRIV \ SkDEBUGCODE(GrSingleOwner::AutoEnforce debug_SingleOwner(fDrawContext->fSingleOwner);) -#define RETURN_IF_ABANDONED if (fDrawingManager->abandoned()) { return; } -#define RETURN_FALSE_IF_ABANDONED if (fDrawingManager->abandoned()) { return false; } -#define RETURN_FALSE_IF_ABANDONED_PRIV if (fDrawContext->fDrawingManager->abandoned()) { return false; } -#define RETURN_NULL_IF_ABANDONED if (fDrawingManager->abandoned()) { return nullptr; } +#define RETURN_IF_ABANDONED if (fDrawingManager->wasAbandoned()) { return; } +#define RETURN_FALSE_IF_ABANDONED if (fDrawingManager->wasAbandoned()) { return false; } +#define RETURN_FALSE_IF_ABANDONED_PRIV if (fDrawContext->fDrawingManager->wasAbandoned()) { return false; } +#define RETURN_NULL_IF_ABANDONED if (fDrawingManager->wasAbandoned()) { return nullptr; } class AutoCheckFlush { public: @@ -51,6 +51,10 @@ private: GrDrawingManager* fDrawingManager; }; +bool GrDrawContext::wasAbandoned() const { + return fDrawingManager->wasAbandoned(); +} + // In MDB mode the reffing of the 'getLastDrawTarget' call's result allows in-progress // drawTargets to be picked up and added to by drawContexts lower in the call // stack. When this occurs with a closed drawTarget, a new one will be allocated diff --git a/src/gpu/GrDrawingManager.cpp b/src/gpu/GrDrawingManager.cpp index 4b035bc863..1b01b7afda 100644 --- a/src/gpu/GrDrawingManager.cpp +++ b/src/gpu/GrDrawingManager.cpp @@ -58,7 +58,7 @@ void GrDrawingManager::reset() { } void GrDrawingManager::flush() { - if (fFlushing || this->abandoned()) { + if (fFlushing || this->wasAbandoned()) { return; } fFlushing = true; @@ -161,7 +161,7 @@ GrPathRenderer* GrDrawingManager::getPathRenderer(const GrPathRenderer::CanDrawP sk_sp<GrDrawContext> GrDrawingManager::drawContext(sk_sp<GrRenderTarget> rt, const SkSurfaceProps* surfaceProps) { - if (this->abandoned()) { + if (this->wasAbandoned()) { return nullptr; } diff --git a/src/gpu/GrDrawingManager.h b/src/gpu/GrDrawingManager.h index 72db2aec6e..fa644b5286 100644 --- a/src/gpu/GrDrawingManager.h +++ b/src/gpu/GrDrawingManager.h @@ -28,7 +28,7 @@ class GrDrawingManager { public: ~GrDrawingManager(); - bool abandoned() const { return fAbandoned; } + bool wasAbandoned() const { return fAbandoned; } void freeGpuResources(); sk_sp<GrDrawContext> drawContext(sk_sp<GrRenderTarget> rt, const SkSurfaceProps*); diff --git a/src/gpu/GrPathRenderingDrawContext.cpp b/src/gpu/GrPathRenderingDrawContext.cpp index 3ca742c873..becffe0179 100644 --- a/src/gpu/GrPathRenderingDrawContext.cpp +++ b/src/gpu/GrPathRenderingDrawContext.cpp @@ -13,7 +13,7 @@ #define ASSERT_SINGLE_OWNER \ SkDEBUGCODE(GrSingleOwner::AutoEnforce debug_SingleOwner(this->singleOwner());) -#define RETURN_IF_ABANDONED if (this->drawingManager()->abandoned()) { return; } +#define RETURN_IF_ABANDONED if (this->drawingManager()->wasAbandoned()) { return; } void GrPathRenderingDrawContext::drawText(const GrClip& clip, const GrPaint& grPaint, const SkPaint& skPaint, |