diff options
author | 2015-11-04 08:34:07 -0800 | |
---|---|---|
committer | 2015-11-04 08:34:07 -0800 | |
commit | 6f45c1714786a54adec156f2416a14aa142adf05 (patch) | |
tree | 9aa6a5a3e76f415db03e25fc8f0c9c7d64e85b69 /src | |
parent | 81919d3c67c5cb74e6ff229d185e4508a9b03ef9 (diff) |
Revert[4] of "stop using drawSprite (at least w/ no filters) as it is going away"
This reverts commit 67b8b5e67a427382fed8c5d8b3c70a21ed2492c6.
BUG=skia:
TBR=
Previous revert was due to faulty unittest (now fixed) -- unrelated to this CL.
Review URL: https://codereview.chromium.org/1422703009
Diffstat (limited to 'src')
-rw-r--r-- | src/effects/SkColorFilterImageFilter.cpp | 3 | ||||
-rwxr-xr-x | src/effects/SkMergeImageFilter.cpp | 2 | ||||
-rw-r--r-- | src/gpu/GrRecordReplaceDraw.cpp | 12 | ||||
-rw-r--r-- | src/images/SkImageDecoder.cpp | 4 |
4 files changed, 11 insertions, 10 deletions
diff --git a/src/effects/SkColorFilterImageFilter.cpp b/src/effects/SkColorFilterImageFilter.cpp index acdb6ab7a7..8d394aa17b 100644 --- a/src/effects/SkColorFilterImageFilter.cpp +++ b/src/effects/SkColorFilterImageFilter.cpp @@ -79,7 +79,8 @@ bool SkColorFilterImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& sourc paint.setXfermodeMode(SkXfermode::kSrc_Mode); paint.setColorFilter(fColorFilter); - canvas.drawSprite(src, srcOffset.fX - bounds.fLeft, srcOffset.fY - bounds.fTop, &paint); + canvas.drawBitmap(src, SkIntToScalar(srcOffset.fX - bounds.fLeft), + SkIntToScalar(srcOffset.fY - bounds.fTop), &paint); *result = device.get()->accessBitmap(false); offset->fX = bounds.fLeft; diff --git a/src/effects/SkMergeImageFilter.cpp b/src/effects/SkMergeImageFilter.cpp index e99991898c..d6f0eaa794 100755 --- a/src/effects/SkMergeImageFilter.cpp +++ b/src/effects/SkMergeImageFilter.cpp @@ -91,7 +91,7 @@ bool SkMergeImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& src, } else { paint.setXfermode(nullptr); } - canvas.drawSprite(input, pos.x() - x0, pos.y() - y0, &paint); + canvas.drawBitmap(input, SkIntToScalar(pos.x() - x0), SkIntToScalar(pos.y() - y0), &paint); didProduceResult = true; } diff --git a/src/gpu/GrRecordReplaceDraw.cpp b/src/gpu/GrRecordReplaceDraw.cpp index bca9255856..28f27dfc1c 100644 --- a/src/gpu/GrRecordReplaceDraw.cpp +++ b/src/gpu/GrRecordReplaceDraw.cpp @@ -35,22 +35,22 @@ static inline void draw_replacement_bitmap(GrCachedLayer* layer, SkCanvas* canva !layer->isAtlased() ? layer->rect().height() : layer->texture()->height(), &bm); + canvas->save(); + canvas->setMatrix(SkMatrix::I()); if (layer->isAtlased()) { const SkRect src = SkRect::Make(layer->rect()); const SkRect dst = SkRect::Make(layer->srcIR()); SkASSERT(layer->offset().isZero()); - canvas->save(); - canvas->setMatrix(SkMatrix::I()); canvas->drawBitmapRect(bm, src, dst, layer->paint(), SkCanvas::kStrict_SrcRectConstraint); - canvas->restore(); } else { - canvas->drawSprite(bm, - layer->srcIR().fLeft + layer->offset().fX, - layer->srcIR().fTop + layer->offset().fY, + canvas->drawBitmap(bm, + SkIntToScalar(layer->srcIR().fLeft + layer->offset().fX), + SkIntToScalar(layer->srcIR().fTop + layer->offset().fY), layer->paint()); } + canvas->restore(); } // Used by GrRecordReplaceDraw. It intercepts nested drawPicture calls and diff --git a/src/images/SkImageDecoder.cpp b/src/images/SkImageDecoder.cpp index daeee9f0b9..60cc44c5b4 100644 --- a/src/images/SkImageDecoder.cpp +++ b/src/images/SkImageDecoder.cpp @@ -206,8 +206,8 @@ bool SkImageDecoder::cropBitmap(SkBitmap *dst, SkBitmap *src, int sampleSize, paint.setXfermodeMode(SkXfermode::kSrc_Mode); SkCanvas canvas(*dst); - canvas.drawSprite(*src, (srcX - dstX) / sampleSize, - (srcY - dstY) / sampleSize, + canvas.drawBitmap(*src, SkIntToScalar((srcX - dstX) / sampleSize), + SkIntToScalar((srcY - dstY) / sampleSize), &paint); return true; } |