diff options
| author |  Jim Van Verth <jvanverth@google.com> | 2018-04-19 14:47:53 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-04-19 21:21:44 +0000 |
| commit | d75b34394b5c53b0a5e8144dd28f956fbc8b90b2 (patch) | |
| tree | 8b13f2d839422ef143b8865ef92c134a81be3b3f /src/utils | |
| parent | fb9f39a98a82f85b046bdd4ab1db68e4fc1f322c (diff) | |
Remove ambient clamp hack for analytic shadows.
The hack was added to make analytic ambient shadows match the geometric
ones exactly. Removing it does produce a slight difference, but it's
only visible at full black values (and then, only slightly) and this
makes room to pass a blend parameter for falloff.
Also fixes an issue with filling out arcs in the shadow tesselator.
Bug: skia:7486
Change-Id: If78d0104df7e18f4320c1658af75576f6a4a8c73
Reviewed-on: https://skia-review.googlesource.com/122580
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Diffstat (limited to 'src/utils')
| -rwxr-xr-x | src/utils/SkShadowTessellator.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/utils/SkShadowTessellator.cpp b/src/utils/SkShadowTessellator.cpp index 98c47a6f2d..0bf1adaaa4 100755 --- a/src/utils/SkShadowTessellator.cpp +++ b/src/utils/SkShadowTessellator.cpp @@ -121,7 +121,7 @@ static void compute_radial_steps(const SkVector& v1, const SkVector& v2, SkScala SkScalar rSin = v1.cross(v2); SkScalar theta = SkScalarATan2(rSin, rCos); - int steps = SkScalarFloorToInt(r*theta*kRecipPixelsPerArcSegment); + int steps = SkScalarRoundToInt(SkScalarAbs(r*theta*kRecipPixelsPerArcSegment)); SkScalar dTheta = theta / steps; *rotSin = SkScalarSinCos(dTheta, rotCos); |