aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/utils/SkDashPath.cpp
diff options
context:
space:
mode:
authorGravatar caryclark <caryclark@google.com>2015-12-09 12:02:30 -0800
committerGravatar Commit bot <commit-bot@chromium.org>2015-12-09 12:02:30 -0800
commit3127c99986dc932343aae5ccc575237d99c3aaec (patch)
tree68b3bf28a8f38c10838afa7a2b28478ad07ff17f /src/utils/SkDashPath.cpp
parente36ec871768eb4f5372540c1167ff7ec592f2bec (diff)
ubsan shift fixes
Use an inline function that does a normal shift. When built for the sanitizer, add casts so that the shift is unsigned. Also make a few fixes to do unsigned shifts or avoid the shift altogether; and add an argument spec to some macros. R=reed@google.com,mtklein@google.com BUG=skia:4633 Review URL: https://codereview.chromium.org/1503423003
Diffstat (limited to 'src/utils/SkDashPath.cpp')
-rw-r--r--src/utils/SkDashPath.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/utils/SkDashPath.cpp b/src/utils/SkDashPath.cpp
index e0cbe9732d..4e34b87eac 100644
--- a/src/utils/SkDashPath.cpp
+++ b/src/utils/SkDashPath.cpp
@@ -10,7 +10,7 @@
#include "SkStrokeRec.h"
static inline int is_even(int x) {
- return (~x) << 31;
+ return !(x & 1);
}
static SkScalar find_first_interval(const SkScalar intervals[], SkScalar phase,