diff options
author | Mike Klein <mtklein@chromium.org> | 2018-05-30 11:33:20 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-05-30 17:09:08 +0000 |
commit | 588f879677d4f36e16a42dd96876534f104c2e2f (patch) | |
tree | bdca8a096ff6b997e255924187adee17b538f0e0 /src/shaders | |
parent | 35fe3ab56994b92e40cd2604e0d897da7dfb0b53 (diff) |
warmup, remove clamping in append_gamut_transform()
Clamping here seems inconsistent with our color pipeline model,
and with the existing GPU impl. The SkRasterPipeline store
stages already do clamp when storing unorms, and table-lookup
stages clamp their inputs, so it should be safe.
While refactoring, slim its interface down a bit.
Change-Id: I4772457fdf90e483834d034f02974d7a859cbe24
Reviewed-on: https://skia-review.googlesource.com/130902
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'src/shaders')
-rw-r--r-- | src/shaders/SkImageShader.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/shaders/SkImageShader.cpp b/src/shaders/SkImageShader.cpp index 8ef647f5c9..bd1b17f029 100644 --- a/src/shaders/SkImageShader.cpp +++ b/src/shaders/SkImageShader.cpp @@ -411,7 +411,9 @@ bool SkImageShader::onAppendStages(const StageRec& rec) const { p->append(fClampAsIfUnpremul ? SkRasterPipeline::clamp_1 : SkRasterPipeline::clamp_a); } - append_gamut_transform(p, alloc, info.colorSpace(), rec.fDstCS, + append_gamut_transform(p, alloc, + info.colorSpace(), + rec.fDstCS, fClampAsIfUnpremul ? kUnpremul_SkAlphaType : kPremul_SkAlphaType); return true; }; |