From 588f879677d4f36e16a42dd96876534f104c2e2f Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Wed, 30 May 2018 11:33:20 -0400 Subject: warmup, remove clamping in append_gamut_transform() Clamping here seems inconsistent with our color pipeline model, and with the existing GPU impl. The SkRasterPipeline store stages already do clamp when storing unorms, and table-lookup stages clamp their inputs, so it should be safe. While refactoring, slim its interface down a bit. Change-Id: I4772457fdf90e483834d034f02974d7a859cbe24 Reviewed-on: https://skia-review.googlesource.com/130902 Reviewed-by: Brian Osman Commit-Queue: Mike Klein --- src/shaders/SkImageShader.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/shaders') diff --git a/src/shaders/SkImageShader.cpp b/src/shaders/SkImageShader.cpp index 8ef647f5c9..bd1b17f029 100644 --- a/src/shaders/SkImageShader.cpp +++ b/src/shaders/SkImageShader.cpp @@ -411,7 +411,9 @@ bool SkImageShader::onAppendStages(const StageRec& rec) const { p->append(fClampAsIfUnpremul ? SkRasterPipeline::clamp_1 : SkRasterPipeline::clamp_a); } - append_gamut_transform(p, alloc, info.colorSpace(), rec.fDstCS, + append_gamut_transform(p, alloc, + info.colorSpace(), + rec.fDstCS, fClampAsIfUnpremul ? kUnpremul_SkAlphaType : kPremul_SkAlphaType); return true; }; -- cgit v1.2.3