diff options
| author |  caryclark <caryclark@google.com> | 2015-12-09 12:02:30 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-12-09 12:02:30 -0800 |
| commit | 3127c99986dc932343aae5ccc575237d99c3aaec (patch) | |
| tree | 68b3bf28a8f38c10838afa7a2b28478ad07ff17f /src/ports | |
| parent | e36ec871768eb4f5372540c1167ff7ec592f2bec (diff) | |
ubsan shift fixes
Use an inline function that does a normal shift. When built for the sanitizer, add casts so that the shift is unsigned.
Also make a few fixes to do unsigned shifts or avoid the shift altogether; and add an argument spec to some macros.
R=reed@google.com,mtklein@google.com
BUG=skia:4633
Review URL: https://codereview.chromium.org/1503423003
Diffstat (limited to 'src/ports')
| -rw-r--r-- | src/ports/SkFontMgr_android_parser.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ports/SkFontMgr_android_parser.h b/src/ports/SkFontMgr_android_parser.h index aca1573952..b841bc6d18 100644 --- a/src/ports/SkFontMgr_android_parser.h +++ b/src/ports/SkFontMgr_android_parser.h @@ -211,7 +211,7 @@ template <int N, typename T> static bool parse_fixed(const char* s, T* value) { n = -n; frac = -frac; } - *value = (n << N) + frac; + *value = SkLeftShift(n, N) + frac; return true; } |