diff options
author | 2014-09-03 11:54:58 -0700 | |
---|---|---|
committer | 2014-09-03 11:54:58 -0700 | |
commit | e5ea500d4714a7d84de2bf913e81be3b65d2de68 (patch) | |
tree | 0c94feeb709b17b954f5e97fad463ec9cfc4dc18 /src/gpu | |
parent | 42b0dfeb29e993b7fd247dcecff705d3dd4cf191 (diff) |
Hide fields in SkImageInfo
R=rmistry@google.com
TBR=bsalomon
Author: reed@google.com
Review URL: https://codereview.chromium.org/536003002
Diffstat (limited to 'src/gpu')
-rw-r--r-- | src/gpu/GrSurface.cpp | 9 | ||||
-rw-r--r-- | src/gpu/SkGpuDevice.cpp | 14 | ||||
-rw-r--r-- | src/gpu/SkGrPixelRef.cpp | 8 |
3 files changed, 15 insertions, 16 deletions
diff --git a/src/gpu/GrSurface.cpp b/src/gpu/GrSurface.cpp index 54497fe8c8..52ab4fd11d 100644 --- a/src/gpu/GrSurface.cpp +++ b/src/gpu/GrSurface.cpp @@ -13,14 +13,11 @@ #include <stdio.h> SkImageInfo GrSurface::info() const { - SkImageInfo info; - if (!GrPixelConfig2ColorType(this->config(), &info.fColorType)) { + SkColorType colorType; + if (!GrPixelConfig2ColorType(this->config(), &colorType)) { sk_throw(); } - info.fWidth = this->width(); - info.fHeight = this->height(); - info.fAlphaType = kPremul_SkAlphaType; - return info; + return SkImageInfo::Make(this->width(), this->height(), colorType, kPremul_SkAlphaType); } bool GrSurface::savePixels(const char* filename) { diff --git a/src/gpu/SkGpuDevice.cpp b/src/gpu/SkGpuDevice.cpp index d26d4f8ed2..1b6558ce43 100644 --- a/src/gpu/SkGpuDevice.cpp +++ b/src/gpu/SkGpuDevice.cpp @@ -168,17 +168,19 @@ SkGpuDevice* SkGpuDevice::Create(GrContext* context, const SkImageInfo& origInfo return NULL; } - SkImageInfo info = origInfo; + SkColorType ct = origInfo.colorType(); + SkAlphaType at = origInfo.alphaType(); // TODO: perhas we can loosen this check now that colortype is more detailed // e.g. can we support both RGBA and BGRA here? - if (kRGB_565_SkColorType == info.colorType()) { - info.fAlphaType = kOpaque_SkAlphaType; // force this setting + if (kRGB_565_SkColorType == ct) { + at = kOpaque_SkAlphaType; // force this setting } else { - info.fColorType = kN32_SkColorType; - if (kOpaque_SkAlphaType != info.alphaType()) { - info.fAlphaType = kPremul_SkAlphaType; // force this setting + ct = kN32_SkColorType; + if (kOpaque_SkAlphaType != at) { + at = kPremul_SkAlphaType; // force this setting } } + const SkImageInfo info = SkImageInfo::Make(origInfo.width(), origInfo.height(), ct, at); GrTextureDesc desc; desc.fFlags = kRenderTarget_GrTextureFlagBit; diff --git a/src/gpu/SkGrPixelRef.cpp b/src/gpu/SkGrPixelRef.cpp index 2371ea72e3..f56c3b6390 100644 --- a/src/gpu/SkGrPixelRef.cpp +++ b/src/gpu/SkGrPixelRef.cpp @@ -116,8 +116,8 @@ SkGrPixelRef::SkGrPixelRef(const SkImageInfo& info, GrSurface* surface, fUnlock = transferCacheLock; if (fSurface) { - SkASSERT(info.fWidth <= fSurface->width()); - SkASSERT(info.fHeight <= fSurface->height()); + SkASSERT(info.width() <= fSurface->width()); + SkASSERT(info.height() <= fSurface->height()); } } @@ -166,9 +166,9 @@ bool SkGrPixelRef::onReadPixels(SkBitmap* dst, const SkIRect* subset) { height = subset->height(); } else { left = 0; - width = this->info().fWidth; + width = this->info().width(); top = 0; - height = this->info().fHeight; + height = this->info().height(); } if (!dst->tryAllocN32Pixels(width, height)) { SkDebugf("SkGrPixelRef::onReadPixels failed to alloc bitmap for result!\n"); |