diff options
author | 2014-11-10 08:10:42 -0800 | |
---|---|---|
committer | 2014-11-10 08:10:42 -0800 | |
commit | a63f32e879a67c84f820c32ac2b10ffd7b2940b8 (patch) | |
tree | 20bc957d064ba229cb36a58dbc5993d4246f59c2 /src/gpu | |
parent | 39fa278c40db07bdcd5a9c8e88b9cfbeefc43e5b (diff) |
Address MSAA rendering in layer hoisting
This became relevant whilst attempting to rebaseline the multipicturedraw GMs after turning on layer hoisting inside Skia.
Review URL: https://codereview.chromium.org/709943003
Diffstat (limited to 'src/gpu')
-rw-r--r-- | src/gpu/GrLayerCache.cpp | 1 | ||||
-rw-r--r-- | src/gpu/GrLayerHoister.cpp | 20 | ||||
-rw-r--r-- | src/gpu/GrLayerHoister.h | 8 | ||||
-rw-r--r-- | src/gpu/SkGpuDevice.cpp | 6 |
4 files changed, 25 insertions, 10 deletions
diff --git a/src/gpu/GrLayerCache.cpp b/src/gpu/GrLayerCache.cpp index d4f8b70b39..e4e086a7d8 100644 --- a/src/gpu/GrLayerCache.cpp +++ b/src/gpu/GrLayerCache.cpp @@ -164,6 +164,7 @@ bool GrLayerCache::tryToAtlas(GrCachedLayer* layer, SkDEBUGCODE(GrAutoValidateLayer avl(fAtlas ? fAtlas->getTexture() : NULL, layer);) SkASSERT(PlausiblyAtlasable(desc.fWidth, desc.fHeight)); + SkASSERT(0 == desc.fSampleCnt); if (layer->locked()) { // This layer is already locked diff --git a/src/gpu/GrLayerHoister.cpp b/src/gpu/GrLayerHoister.cpp index 5d3a383b47..c74913d757 100644 --- a/src/gpu/GrLayerHoister.cpp +++ b/src/gpu/GrLayerHoister.cpp @@ -22,7 +22,8 @@ static void prepare_for_hoisting(GrLayerCache* layerCache, const SkIRect& layerRect, SkTDArray<GrHoistedLayer>* needRendering, SkTDArray<GrHoistedLayer>* recycled, - bool attemptToAtlas) { + bool attemptToAtlas, + int numSamples) { const SkPicture* pict = info.fPicture ? info.fPicture : topLevelPicture; SkMatrix combined = SkMatrix::Concat(info.fPreMat, info.fLocalMat); @@ -38,7 +39,7 @@ static void prepare_for_hoisting(GrLayerCache* layerCache, desc.fWidth = layerRect.width(); desc.fHeight = layerRect.height(); desc.fConfig = kSkia8888_GrPixelConfig; - // TODO: need to deal with sample count + desc.fSampleCnt = numSamples; bool locked, needsRendering; if (attemptToAtlas) { @@ -81,7 +82,13 @@ void GrLayerHoister::FindLayersToAtlas(GrContext* context, const SkPicture* topLevelPicture, const SkRect& query, SkTDArray<GrHoistedLayer>* atlased, - SkTDArray<GrHoistedLayer>* recycled) { + SkTDArray<GrHoistedLayer>* recycled, + int numSamples) { + if (0 != numSamples) { + // MSAA layers are currently never atlased + return; + } + GrLayerCache* layerCache = context->getLayerCache(); layerCache->processDeletedPictures(); @@ -123,7 +130,7 @@ void GrLayerHoister::FindLayersToAtlas(GrContext* context, continue; } - prepare_for_hoisting(layerCache, topLevelPicture, info, ir, atlased, recycled, true); + prepare_for_hoisting(layerCache, topLevelPicture, info, ir, atlased, recycled, true, 0); } } @@ -132,7 +139,8 @@ void GrLayerHoister::FindLayersToHoist(GrContext* context, const SkPicture* topLevelPicture, const SkRect& query, SkTDArray<GrHoistedLayer>* needRendering, - SkTDArray<GrHoistedLayer>* recycled) { + SkTDArray<GrHoistedLayer>* recycled, + int numSamples) { GrLayerCache* layerCache = context->getLayerCache(); layerCache->processDeletedPictures(); @@ -166,7 +174,7 @@ void GrLayerHoister::FindLayersToHoist(GrContext* context, layerRect.roundOut(&ir); prepare_for_hoisting(layerCache, topLevelPicture, info, ir, - needRendering, recycled, false); + needRendering, recycled, false, numSamples); } } diff --git a/src/gpu/GrLayerHoister.h b/src/gpu/GrLayerHoister.h index c3a451df57..0780c1e801 100644 --- a/src/gpu/GrLayerHoister.h +++ b/src/gpu/GrLayerHoister.h @@ -41,12 +41,14 @@ public: @param atlasedNeedRendering Out parameter storing the layers that should be hoisted to the atlas @param recycled Out parameter storing layers that are atlased but do not need rendering + @param numSamples The number if MSAA samples required */ static void FindLayersToAtlas(GrContext* context, const SkPicture* topLevelPicture, const SkRect& query, SkTDArray<GrHoistedLayer>* atlasedNeedRendering, - SkTDArray<GrHoistedLayer>* recycled); + SkTDArray<GrHoistedLayer>* recycled, + int numSamples); /** Find the layers in 'topLevelPicture' that need hoisting. Note that the discovered layers can be inside nested sub-pictures. @@ -56,12 +58,14 @@ public: @param needRendering Out parameter storing the layers that need rendering. This should never include atlased layers. @param recycled Out parameter storing layers that need hoisting but not rendering + @param numSamples The number if MSAA samples required */ static void FindLayersToHoist(GrContext* context, const SkPicture* topLevelPicture, const SkRect& query, SkTDArray<GrHoistedLayer>* needRendering, - SkTDArray<GrHoistedLayer>* recycled); + SkTDArray<GrHoistedLayer>* recycled, + int numSamples); /** Draw the specified layers into the atlas. @param context Owner of the layer cache (and thus the layers) diff --git a/src/gpu/SkGpuDevice.cpp b/src/gpu/SkGpuDevice.cpp index 96c071473c..b072142a0b 100644 --- a/src/gpu/SkGpuDevice.cpp +++ b/src/gpu/SkGpuDevice.cpp @@ -1824,7 +1824,8 @@ bool SkGpuDevice::EXPERIMENTAL_drawPicture(SkCanvas* mainCanvas, const SkPicture GrLayerHoister::FindLayersToAtlas(fContext, mainPicture, clipBounds, - &atlasedNeedRendering, &atlasedRecycled); + &atlasedNeedRendering, &atlasedRecycled, + fRenderTarget->numSamples()); GrLayerHoister::DrawLayersToAtlas(fContext, atlasedNeedRendering); @@ -1832,7 +1833,8 @@ bool SkGpuDevice::EXPERIMENTAL_drawPicture(SkCanvas* mainCanvas, const SkPicture GrLayerHoister::FindLayersToHoist(fContext, mainPicture, clipBounds, - &needRendering, &recycled); + &needRendering, &recycled, + fRenderTarget->numSamples()); GrLayerHoister::DrawLayers(fContext, needRendering); |