diff options
author | Brian Salomon <bsalomon@google.com> | 2018-06-23 15:17:27 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-06-25 17:55:45 +0000 |
commit | ff168d9258e0101826a8072b4ee077c3d2aa7258 (patch) | |
tree | c8338ce3ffb83b18575785a3bd98b2607e59bb1a /src/gpu/glsl | |
parent | 721e63727f38b9c7664a173ab475d7c7a58cd8a8 (diff) |
Put GrPrimitiveProcessor/GrGeometryProcessor before GrPipeline in param lists.
We were inconsistent about which order these were in. Having the processor first
will make the parameter order more logical for an upcoming change. Also, the primitive
processor comes logically before the pipeline.
Change-Id: I3968c5e4e6dff01f9c4ad311eb1795b3c7580ff5
Reviewed-on: https://skia-review.googlesource.com/137228
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Diffstat (limited to 'src/gpu/glsl')
-rw-r--r-- | src/gpu/glsl/GrGLSLProgramBuilder.cpp | 29 | ||||
-rw-r--r-- | src/gpu/glsl/GrGLSLProgramBuilder.h | 4 |
2 files changed, 15 insertions, 18 deletions
diff --git a/src/gpu/glsl/GrGLSLProgramBuilder.cpp b/src/gpu/glsl/GrGLSLProgramBuilder.cpp index cae1c2ad65..19600a27e5 100644 --- a/src/gpu/glsl/GrGLSLProgramBuilder.cpp +++ b/src/gpu/glsl/GrGLSLProgramBuilder.cpp @@ -19,22 +19,21 @@ const int GrGLSLProgramBuilder::kVarsPerBlock = 8; -GrGLSLProgramBuilder::GrGLSLProgramBuilder(const GrPipeline& pipeline, - const GrPrimitiveProcessor& primProc, +GrGLSLProgramBuilder::GrGLSLProgramBuilder(const GrPrimitiveProcessor& primProc, + const GrPipeline& pipeline, GrProgramDesc* desc) - : fVS(this) - , fGS(this) - , fFS(this) - , fStageIndex(-1) - , fPipeline(pipeline) - , fPrimProc(primProc) - , fDesc(desc) - , fGeometryProcessor(nullptr) - , fXferProcessor(nullptr) - , fNumVertexSamplers(0) - , fNumGeometrySamplers(0) - , fNumFragmentSamplers(0) { -} + : fVS(this) + , fGS(this) + , fFS(this) + , fStageIndex(-1) + , fPipeline(pipeline) + , fPrimProc(primProc) + , fDesc(desc) + , fGeometryProcessor(nullptr) + , fXferProcessor(nullptr) + , fNumVertexSamplers(0) + , fNumGeometrySamplers(0) + , fNumFragmentSamplers(0) {} void GrGLSLProgramBuilder::addFeature(GrShaderFlags shaders, uint32_t featureBit, diff --git a/src/gpu/glsl/GrGLSLProgramBuilder.h b/src/gpu/glsl/GrGLSLProgramBuilder.h index 7d0ce74abe..c53cf19da8 100644 --- a/src/gpu/glsl/GrGLSLProgramBuilder.h +++ b/src/gpu/glsl/GrGLSLProgramBuilder.h @@ -93,9 +93,7 @@ public: int fFragmentProcessorCnt; protected: - explicit GrGLSLProgramBuilder(const GrPipeline&, - const GrPrimitiveProcessor&, - GrProgramDesc*); + explicit GrGLSLProgramBuilder(const GrPrimitiveProcessor&, const GrPipeline&, GrProgramDesc*); void addFeature(GrShaderFlags shaders, uint32_t featureBit, const char* extensionName); |