diff options
author | 2016-01-08 12:11:39 -0800 | |
---|---|---|
committer | 2016-01-08 12:11:39 -0800 | |
commit | 3183a4136364cfe18b3584302e71ea528a018401 (patch) | |
tree | 00dc9f7509516757e84de9c311a413743af1275f /src/gpu/gl/GrGLCaps.h | |
parent | defa0daa6a0f4e97a3527a522ae602c6771a7c80 (diff) |
Revert of Add a class representing texture swizzle. (patchset #6 id:100001 of https://codereview.chromium.org/1567733005/ )
Reason for revert:
Shader compilation failures when implicitly converting vec4 to float.
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Debug/builds/3266/steps/dm/logs/stdio
https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug/builds/3154/steps/dm/logs/stdio
Original issue's description:
> Add a class representing texture swizzle.
>
> Store config swizzle GrGLCaps and shader swizzles in GrGLSLCaps.
>
> Remove GrTextureAccess's swizzle and update users of it to swizzle in their shader code.
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1567733005
>
> Committed: https://skia.googlesource.com/skia/+/1a1efeacf7cc94a8c2977114dfe230fed3efc105
TBR=egdaniel@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1569393002
Diffstat (limited to 'src/gpu/gl/GrGLCaps.h')
-rw-r--r-- | src/gpu/gl/GrGLCaps.h | 19 |
1 files changed, 5 insertions, 14 deletions
diff --git a/src/gpu/gl/GrGLCaps.h b/src/gpu/gl/GrGLCaps.h index db60ad273a..a650348a13 100644 --- a/src/gpu/gl/GrGLCaps.h +++ b/src/gpu/gl/GrGLCaps.h @@ -9,10 +9,9 @@ #ifndef GrGLCaps_DEFINED #define GrGLCaps_DEFINED -#include "glsl/GrGLSL.h" #include "GrCaps.h" +#include "glsl/GrGLSL.h" #include "GrGLStencilAttachment.h" -#include "GrSwizzle.h" #include "SkChecksum.h" #include "SkTHash.h" #include "SkTArray.h" @@ -143,11 +142,6 @@ public: return fConfigTable[config].fFormats; } - /** Returns the mapping between GrPixelConfig components and GL internal format components. */ - const GrSwizzle& configSwizzle(GrPixelConfig config) const { - return fConfigTable[config].fSwizzle; - } - /** * Gets an array of legal stencil formats. These formats are not guaranteed * to be supported by the driver but are legal GLenum names given the GL @@ -313,9 +307,6 @@ public: /// Are textures with GL_TEXTURE_EXTERNAL_OES type supported. bool externalTextureSupport() const { return fExternalTextureSupport; } - /// GL_ARB_texture_swizzle - bool textureSwizzleSupport() const { return fTextureSwizzleSupport; } - /** * Is there support for enabling/disabling sRGB writes for sRGB-capable color attachments? * If false this does not mean sRGB is not supported but rather that if it is supported @@ -344,12 +335,15 @@ private: void initBlendEqationSupport(const GrGLContextInfo&); void initStencilFormats(const GrGLContextInfo&); // This must be called after initFSAASupport(). - void initConfigTable(const GrGLContextInfo&, const GrGLInterface* gli, GrGLSLCaps* glslCaps); + void initConfigTable(const GrGLContextInfo&, const GrGLInterface* gli); void initShaderPrecisionTable(const GrGLContextInfo& ctxInfo, const GrGLInterface* intf, GrGLSLCaps* glslCaps); + void initConfigSwizzleTable(const GrGLContextInfo& ctxInfo, GrGLSLCaps* glslCaps); + + SkTArray<StencilFormat, true> fStencilFormats; int fMaxFragmentUniformVectors; @@ -382,7 +376,6 @@ private: bool fPartialFBOReadIsSlow : 1; bool fBindUniformLocationSupport : 1; bool fExternalTextureSupport : 1; - bool fTextureSwizzleSupport : 1; /** Number type of the components (with out considering number of bits.) */ enum FormatType { @@ -425,8 +418,6 @@ private: kRenderableWithMSAA_Flag = 0x8, }; uint32_t fFlags; - - GrSwizzle fSwizzle; }; ConfigInfo fConfigTable[kGrPixelConfigCnt]; |