diff options
| author |  Brian Salomon <bsalomon@google.com> | 2018-07-10 20:34:16 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-07-10 20:34:26 +0000 |
| commit | 1b112cc5604d294427c0d51f194ab7fb3067d9e2 (patch) | |
| tree | ddf61ad9a83efa733b03ce6970a716f6f68e3566 /src/gpu/gl/GrGLCaps.cpp | |
| parent | d275ef501c8e6ea6444912e22c29e2d13a3dfb53 (diff) | |
Revert "Remove interpolants are inaccurate workaround for Adreno 3xx."
This reverts commit a7a278205bb040061cb4ba46839efe18635c7edc.
Reason for revert: Chrome change had to be reverted because of new failures on Nexus 9 and 6P.
Original change's description:
> Remove interpolants are inaccurate workaround for Adreno 3xx.
>
> The chrome screenshot unit test that led to adding this workaround has
> been adjusted to avoid testing AA edges of rendered rectangles. We're
> accepting the inaccuracy in favor of increased performance.
>
> Chrome change: https://chromium-review.googlesource.com/c/chromium/src/+/1129041
>
> Bug: chromium:847984
> Change-Id: I9b714ade2a67e956ebb2773ebe3b8632dc3a50c6
> Reviewed-on: https://skia-review.googlesource.com/140180
> Commit-Queue: Brian Salomon <bsalomon@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Auto-Submit: Brian Salomon <bsalomon@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>
TBR=bsalomon@google.com,brianosman@google.com
Change-Id: Ic6b0e5a343556e59d144852f9fa5b561302f9781
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:847984
Reviewed-on: https://skia-review.googlesource.com/140380
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Diffstat (limited to 'src/gpu/gl/GrGLCaps.cpp')
| -rw-r--r-- | src/gpu/gl/GrGLCaps.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp index 2b923fa4ac..5cb23427c5 100644 --- a/src/gpu/gl/GrGLCaps.cpp +++ b/src/gpu/gl/GrGLCaps.cpp @@ -2608,9 +2608,11 @@ void GrGLCaps::applyDriverCorrectnessWorkarounds(const GrGLContextInfo& ctxInfo, #endif // We've seen Adreno 3xx devices produce incorrect (flipped) values for gl_FragCoord, in some - // (rare) situations. It's sporadic, and mostly on older drivers. + // (rare) situations. It's sporadic, and mostly on older drivers. It also seems to be the case + // that the interpolation of vertex shader outputs is quite inaccurate. if (kAdreno3xx_GrGLRenderer == ctxInfo.renderer()) { shaderCaps->fCanUseFragCoord = false; + shaderCaps->fInterpolantsAreInaccurate = true; } // gl_FragCoord has an incorrect subpixel offset on legacy Tegra hardware. |