diff options
author | 2012-12-20 14:18:10 +0000 | |
---|---|---|
committer | 2012-12-20 14:18:10 +0000 | |
commit | 4b86e3428b115202e82d49a0914ea8ab6dc25940 (patch) | |
tree | d519732030f8abec0f9e8a31b4ce87c1035cfe3e /src/gpu/GrContext.cpp | |
parent | 9532953aa11289aea7c1fbd1438adca61a34bb24 (diff) |
Simplify cache IDs and keys.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6954047
git-svn-id: http://skia.googlecode.com/svn/trunk@6914 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'src/gpu/GrContext.cpp')
-rw-r--r-- | src/gpu/GrContext.cpp | 45 |
1 files changed, 21 insertions, 24 deletions
diff --git a/src/gpu/GrContext.cpp b/src/gpu/GrContext.cpp index d00e062fae..12fbeb6e31 100644 --- a/src/gpu/GrContext.cpp +++ b/src/gpu/GrContext.cpp @@ -209,18 +209,20 @@ void convolve_gaussian(GrDrawTarget* target, } +//////////////////////////////////////////////////////////////////////////////// + GrTexture* GrContext::findTexture(const GrTextureDesc& desc, - const GrCacheData& cacheData, + const GrCacheID& cacheID, const GrTextureParams* params) { - GrResourceKey resourceKey = GrTexture::ComputeKey(fGpu, params, desc, cacheData, false); + GrResourceKey resourceKey = GrTexture::ComputeKey(fGpu, params, desc, cacheID); GrResource* resource = fTextureCache->find(resourceKey); return static_cast<GrTexture*>(resource); } bool GrContext::isTextureInCache(const GrTextureDesc& desc, - const GrCacheData& cacheData, + const GrCacheID& cacheID, const GrTextureParams* params) const { - GrResourceKey resourceKey = GrTexture::ComputeKey(fGpu, params, desc, cacheData, false); + GrResourceKey resourceKey = GrTexture::ComputeKey(fGpu, params, desc, cacheID); return fTextureCache->hasKey(resourceKey); } @@ -272,13 +274,13 @@ static void stretchImage(void* dst, // The desired texture is NPOT and tiled but that isn't supported by // the current hardware. Resize the texture to be a POT GrTexture* GrContext::createResizedTexture(const GrTextureDesc& desc, - const GrCacheData& cacheData, + const GrCacheID& cacheID, void* srcData, size_t rowBytes, bool needsFiltering) { - GrTexture* clampedTexture = this->findTexture(desc, cacheData, NULL); + GrTexture* clampedTexture = this->findTexture(desc, cacheID, NULL); if (NULL == clampedTexture) { - clampedTexture = this->createTexture(NULL, desc, cacheData, srcData, rowBytes); + clampedTexture = this->createTexture(NULL, desc, cacheID, srcData, rowBytes); if (NULL == clampedTexture) { return NULL; @@ -350,22 +352,22 @@ GrTexture* GrContext::createResizedTexture(const GrTextureDesc& desc, GrTexture* GrContext::createTexture( const GrTextureParams* params, const GrTextureDesc& desc, - const GrCacheData& cacheData, + const GrCacheID& cacheID, void* srcData, size_t rowBytes) { - SK_TRACE_EVENT0("GrContext::createAndLockTexture"); + SK_TRACE_EVENT0("GrContext::createTexture"); #if GR_DUMP_TEXTURE_UPLOAD - GrPrintf("GrContext::createAndLockTexture [%d %d]\n", desc.fWidth, desc.fHeight); + GrPrintf("GrContext::createTexture[%d %d]\n", desc.fWidth, desc.fHeight); #endif - GrResourceKey resourceKey = GrTexture::ComputeKey(fGpu, params, desc, cacheData, false); + GrResourceKey resourceKey = GrTexture::ComputeKey(fGpu, params, desc, cacheID); SkAutoTUnref<GrTexture> texture; if (GrTexture::NeedsResizing(resourceKey)) { - texture.reset(this->createResizedTexture(desc, cacheData, - srcData, rowBytes, - GrTexture::NeedsFiltering(resourceKey))); + texture.reset(this->createResizedTexture(desc, cacheID, + srcData, rowBytes, + GrTexture::NeedsFiltering(resourceKey))); } else { texture.reset(fGpu->createTexture(desc, srcData, rowBytes)); } @@ -377,15 +379,13 @@ GrTexture* GrContext::createTexture( return texture; } -GrTexture* GrContext::lockScratchTexture(const GrTextureDesc& inDesc, - ScratchTexMatch match) { +GrTexture* GrContext::lockScratchTexture(const GrTextureDesc& inDesc, ScratchTexMatch match) { GrTextureDesc desc = inDesc; - GrCacheData cacheData(GrCacheData::kScratch_CacheID); GrAssert((desc.fFlags & kRenderTarget_GrTextureFlagBit) || !(desc.fFlags & kNoStencil_GrTextureFlagBit)); - if (kExact_ScratchTexMatch != match) { + if (kApprox_ScratchTexMatch == match) { // bin by pow2 with a reasonable min static const int MIN_SIZE = 256; desc.fWidth = GrMax(MIN_SIZE, GrNextPow2(desc.fWidth)); @@ -399,7 +399,7 @@ GrTexture* GrContext::lockScratchTexture(const GrTextureDesc& inDesc, bool doubledH = false; do { - GrResourceKey key = GrTexture::ComputeKey(fGpu, NULL, desc, cacheData, true); + GrResourceKey key = GrTexture::ComputeScratchKey(desc); // Ensure we have exclusive access to the texture so future 'find' calls don't return it resource = fTextureCache->find(key, GrResourceCache::kHide_OwnershipFlag); // if we miss, relax the fit of the flags... @@ -433,10 +433,7 @@ GrTexture* GrContext::lockScratchTexture(const GrTextureDesc& inDesc, desc.fHeight = origHeight; SkAutoTUnref<GrTexture> texture(fGpu->createTexture(desc, NULL, 0)); if (NULL != texture) { - GrResourceKey key = GrTexture::ComputeKey(fGpu, NULL, - texture->desc(), - cacheData, - true); + GrResourceKey key = GrTexture::ComputeScratchKey(texture->desc()); // Make the resource exclusive so future 'find' calls don't return it fTextureCache->addResource(key, texture, GrResourceCache::kHide_OwnershipFlag); resource = texture; @@ -475,7 +472,7 @@ void GrContext::unlockScratchTexture(GrTexture* texture) { // If this is a scratch texture we detached it from the cache // while it was locked (to avoid two callers simultaneously getting // the same texture). - if (GrTexture::IsScratchTexture(texture->getCacheEntry()->key())) { + if (texture->getCacheEntry()->key().isScratch()) { fTextureCache->makeNonExclusive(texture->getCacheEntry()); } |