diff options
author | Mike Reed <reed@google.com> | 2018-03-07 14:16:52 -0500 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-03-07 19:39:00 +0000 |
commit | b5e1f7558052cc60deaf23ccc2c898d1c6c94c09 (patch) | |
tree | b3ee26c7341dc9757ed02e91e3d30b4de32c2b90 /src/core/SkDraw.cpp | |
parent | d2e9f767bbb1a7664e9ee83d0755d7e4327cb7b2 (diff) |
Revert "Revert "add tiler for SkDraw""
This reverts commit 461ef7af88cc966007c464130a971ec86c803f1d.
Prev CL to SkScan_Hairline.cpp fixed the bug that caused the earlier revert.
Bug: skia:
Change-Id: Ifd9a364c7546175be292f726e19465b72196b45e
Reviewed-on: https://skia-review.googlesource.com/112723
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Diffstat (limited to 'src/core/SkDraw.cpp')
-rw-r--r-- | src/core/SkDraw.cpp | 74 |
1 files changed, 32 insertions, 42 deletions
diff --git a/src/core/SkDraw.cpp b/src/core/SkDraw.cpp index 21a89ae5a9..cf06b7b3b5 100644 --- a/src/core/SkDraw.cpp +++ b/src/core/SkDraw.cpp @@ -14,7 +14,6 @@ #include "SkCanvas.h" #include "SkColorData.h" #include "SkDevice.h" -#include "SkDeviceLooper.h" #include "SkDraw.h" #include "SkDrawProcs.h" #include "SkFindAndPlaceGlyph.h" @@ -785,8 +784,7 @@ void SkDraw::drawRect(const SkRect& prePaintRect, const SkPaint& paint, } } - if (!SkRectPriv::MakeLargeS32().contains(bbox)) { - // bbox.roundOut() is undefined; use slow path. + if (!SkRectPriv::FitsInFixed(bbox) && rtype != kHair_RectType) { draw_rect_as_path(*this, prePaintRect, paint, matrix); return; } @@ -796,45 +794,37 @@ void SkDraw::drawRect(const SkRect& prePaintRect, const SkPaint& paint, return; } - SkDeviceLooper looper(fDst, *fRC, ir, paint.isAntiAlias()); - while (looper.next()) { - SkRect localDevRect; - looper.mapRect(&localDevRect, devRect); - SkMatrix localMatrix; - looper.mapMatrix(&localMatrix, *matrix); - - SkAutoBlitterChoose blitterStorage(looper.getPixmap(), localMatrix, paint); - const SkRasterClip& clip = looper.getRC(); - SkBlitter* blitter = blitterStorage.get(); - - // we want to "fill" if we are kFill or kStrokeAndFill, since in the latter - // case we are also hairline (if we've gotten to here), which devolves to - // effectively just kFill - switch (rtype) { - case kFill_RectType: - if (paint.isAntiAlias()) { - SkScan::AntiFillRect(localDevRect, clip, blitter); - } else { - SkScan::FillRect(localDevRect, clip, blitter); - } - break; - case kStroke_RectType: - if (paint.isAntiAlias()) { - SkScan::AntiFrameRect(localDevRect, strokeSize, clip, blitter); - } else { - SkScan::FrameRect(localDevRect, strokeSize, clip, blitter); - } - break; - case kHair_RectType: - if (paint.isAntiAlias()) { - SkScan::AntiHairRect(localDevRect, clip, blitter); - } else { - SkScan::HairRect(localDevRect, clip, blitter); - } - break; - default: - SkDEBUGFAIL("bad rtype"); - } + SkAutoBlitterChoose blitterStorage(fDst, *matrix, paint); + const SkRasterClip& clip = *fRC; + SkBlitter* blitter = blitterStorage.get(); + + // we want to "fill" if we are kFill or kStrokeAndFill, since in the latter + // case we are also hairline (if we've gotten to here), which devolves to + // effectively just kFill + switch (rtype) { + case kFill_RectType: + if (paint.isAntiAlias()) { + SkScan::AntiFillRect(devRect, clip, blitter); + } else { + SkScan::FillRect(devRect, clip, blitter); + } + break; + case kStroke_RectType: + if (paint.isAntiAlias()) { + SkScan::AntiFrameRect(devRect, strokeSize, clip, blitter); + } else { + SkScan::FrameRect(devRect, strokeSize, clip, blitter); + } + break; + case kHair_RectType: + if (paint.isAntiAlias()) { + SkScan::AntiHairRect(devRect, clip, blitter); + } else { + SkScan::HairRect(devRect, clip, blitter); + } + break; + default: + SkDEBUGFAIL("bad rtype"); } } |