diff options
| author |  reed <reed@google.com> | 2015-04-15 14:38:09 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-04-15 14:38:09 -0700 |
| commit | 639a82855b94b93c4fa45560e67df8ec4a8bbb3a (patch) | |
| tree | 6a640af81f07013b7ae04eef650f557228d24480 /src/core/SkCoreBlitters.h | |
| parent | bed83a66f5fa5821a3a08da32157a6155960b15e (diff) | |
Revert of Speeup hairline curves (quads and cubics) (patchset #7 id:120001 of https://codereview.chromium.org/1078413003/)
Reason for revert:
Crazy failings in chrome tests
http://build.chromium.org/p/client.skia/builders/Linux%20Tests/builds/1862
Original issue's description:
> Speeup hairline curves (quads and cubics)
>
> /skia/trunk> cat ../old.txt
> maxrss loops min median mean max stddev samples config bench
> 9M 1 4.28ms 4.32ms 4.36ms 4.67ms 3% ▄▁▁▃▂▂▁▁▂█ 8888 path_hairline_small_AA_cubic
> 9M 1 743µs 767µs 770µs 825µs 4% ▃▃▇▃▁▁▅▁█▁ 8888 path_hairline_small_AA_conic
> 9M 1 533µs 606µs 598µs 680µs 9% ▁▂▂█▆▇▇▄▂▂ 8888 path_hairline_small_AA_quad
> 9M 1 451µs 452µs 456µs 495µs 3% ▁▁▁▁█▁▁▁▁▁ 8888 path_hairline_small_AA_line
>
> /skia/trunk> cat ../new.txt
> maxrss loops min median mean max stddev samples config bench
> 9M 1 827µs 827µs 831µs 869µs 2% ▁▁▁▁▁▁▁█▁▁ 8888 path_hairline_small_AA_cubic
> 9M 1 515µs 517µs 517µs 518µs 0% ▇█▆▅▃▃▁▁▁▅ 8888 path_hairline_small_AA_conic
> 9M 1 310µs 311µs 315µs 332µs 2% ▂▁█▆▁▁▁▁▁▁ 8888 path_hairline_small_AA_quad
> 9M 1 254µs 254µs 258µs 276µs 3% ▁▁▁▁▁▁▁█▇▂ 8888 path_hairline_small_AA_line
>
> Edited revert of https://codereview.chromium.org/1085013003
>
> TBR=
>
> Expectations:
> - no effect on chrome, as it is guarded
> - lots of tiny rebaselines for skia
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1092483003
Diffstat (limited to 'src/core/SkCoreBlitters.h')
| -rw-r--r-- | src/core/SkCoreBlitters.h | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/core/SkCoreBlitters.h b/src/core/SkCoreBlitters.h index acc18febed..f4a5d6f4db 100644 --- a/src/core/SkCoreBlitters.h +++ b/src/core/SkCoreBlitters.h @@ -120,10 +120,6 @@ public: virtual void blitRect(int x, int y, int width, int height); virtual void blitMask(const SkMask&, const SkIRect&); virtual const SkBitmap* justAnOpaqueColor(uint32_t*); -#ifndef SK_SUPPORT_LEGACY_BLITANTIH2V2 - void blitAntiH2(int x, int y, U8CPU a0, U8CPU a1) override; - void blitAntiV2(int x, int y, U8CPU a0, U8CPU a1) override; -#endif protected: SkColor fColor; @@ -144,10 +140,6 @@ public: SkARGB32_Opaque_Blitter(const SkBitmap& device, const SkPaint& paint) : INHERITED(device, paint) { SkASSERT(paint.getAlpha() == 0xFF); } virtual void blitMask(const SkMask&, const SkIRect&); -#ifndef SK_SUPPORT_LEGACY_BLITANTIH2V2 - void blitAntiH2(int x, int y, U8CPU a0, U8CPU a1) override; - void blitAntiV2(int x, int y, U8CPU a0, U8CPU a1) override; -#endif private: typedef SkARGB32_Blitter INHERITED; @@ -158,10 +150,6 @@ public: SkARGB32_Black_Blitter(const SkBitmap& device, const SkPaint& paint) : INHERITED(device, paint) {} virtual void blitAntiH(int x, int y, const SkAlpha antialias[], const int16_t runs[]); -#ifndef SK_SUPPORT_LEGACY_BLITANTIH2V2 - void blitAntiH2(int x, int y, U8CPU a0, U8CPU a1) override; - void blitAntiV2(int x, int y, U8CPU a0, U8CPU a1) override; -#endif private: typedef SkARGB32_Opaque_Blitter INHERITED; |