diff options
| author |  Brian Osman <brianosman@google.com> | 2018-06-18 19:32:04 +0000 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-06-18 19:32:09 +0000 |
| commit | 3ff2b200573354c83bbb52ff2f5f760eb481596e (patch) | |
| tree | 0a658be5c7c7e71746deac8f6ffeb47479f58153 /site/dev | |
| parent | 1c477fc263cf37c27cd92740d9328445420a926d (diff) | |
Revert "Remove old references to SampleApp"
This reverts commit 1c477fc263cf37c27cd92740d9328445420a926d.
Reason for revert: Botpocalypse.
Original change's description:
> Remove old references to SampleApp
>
> Docs-Preview: https://skia.org/?cl=135570
> Change-Id: I330ffa964c2d90ca8d3cd844aabcd8616ccd0540
> Reviewed-on: https://skia-review.googlesource.com/135570
> Reviewed-by: Cary Clark <caryclark@google.com>
> Commit-Queue: Brian Osman <brianosman@google.com>
TBR=halcanary@google.com,brianosman@google.com,caryclark@google.com
Change-Id: I514e2c7bca8a1ebd311593573a94e8a078695785
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/135600
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Diffstat (limited to 'site/dev')
| -rw-r--r-- | site/dev/contrib/submit.md | 7 | ||||
| -rw-r--r-- | site/dev/testing/tests.md | 6 |
2 files changed, 7 insertions, 6 deletions
diff --git a/site/dev/contrib/submit.md b/site/dev/contrib/submit.md index 6627546b61..1d36e1f9d7 100644 --- a/site/dev/contrib/submit.md +++ b/site/dev/contrib/submit.md @@ -45,9 +45,10 @@ Test code is located under the 'tests' directory. See [Writing Unit and Rendering Tests](../testing/tests) for details. Unit tests are best, but if your change touches rendering and you can't think of -an automated way to verify the results, consider writing a GM test. Also, if your -change is in the GPU code, you may not be able to write it as part of the standard -unit test suite, but there are GPU-specific testing paths you can extend. +an automated way to verify the results, consider writing a GM test or a new page +of SampleApp. Also, if your change is the GPU code, you may not be able to write +it as part of the standard unit test suite, but there are GPU-specific testing +paths you can extend. Submitting a patch ------------------ diff --git a/site/dev/testing/tests.md b/site/dev/testing/tests.md index d9c0798b6c..c24a1731e0 100644 --- a/site/dev/testing/tests.md +++ b/site/dev/testing/tests.md @@ -78,12 +78,12 @@ Writing a Rendering Test ninja -C out/Debug dm out/Debug/dm --match newgmtest -4. Run the GM inside Viewer: +4. Run the GM inside SampleApp: <!--?prettify lang=sh?--> - ninja -C out/Debug viewer - out/Debug/viewer --slide GM_newgmtest + ninja -C out/Debug SampleApp + out/Debug/SampleApp --slide GM:newgmtest <span id="bench"></span> |