aboutsummaryrefslogtreecommitdiffhomepage
path: root/site/dev
diff options
context:
space:
mode:
authorGravatar Brian Osman <brianosman@google.com>2018-06-18 14:24:44 -0400
committerGravatar Skia Commit-Bot <skia-commit-bot@chromium.org>2018-06-18 19:15:48 +0000
commit1c477fc263cf37c27cd92740d9328445420a926d (patch)
tree646d1276502c26a9fb8296e4b08e9b7721fae10a /site/dev
parentc00d8627ff8adbc9ba49ab6fcbc356c6db9ffb84 (diff)
Remove old references to SampleApp
Docs-Preview: https://skia.org/?cl=135570 Change-Id: I330ffa964c2d90ca8d3cd844aabcd8616ccd0540 Reviewed-on: https://skia-review.googlesource.com/135570 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
Diffstat (limited to 'site/dev')
-rw-r--r--site/dev/contrib/submit.md7
-rw-r--r--site/dev/testing/tests.md6
2 files changed, 6 insertions, 7 deletions
diff --git a/site/dev/contrib/submit.md b/site/dev/contrib/submit.md
index 1d36e1f9d7..6627546b61 100644
--- a/site/dev/contrib/submit.md
+++ b/site/dev/contrib/submit.md
@@ -45,10 +45,9 @@ Test code is located under the 'tests' directory.
See [Writing Unit and Rendering Tests](../testing/tests) for details.
Unit tests are best, but if your change touches rendering and you can't think of
-an automated way to verify the results, consider writing a GM test or a new page
-of SampleApp. Also, if your change is the GPU code, you may not be able to write
-it as part of the standard unit test suite, but there are GPU-specific testing
-paths you can extend.
+an automated way to verify the results, consider writing a GM test. Also, if your
+change is in the GPU code, you may not be able to write it as part of the standard
+unit test suite, but there are GPU-specific testing paths you can extend.
Submitting a patch
------------------
diff --git a/site/dev/testing/tests.md b/site/dev/testing/tests.md
index c24a1731e0..d9c0798b6c 100644
--- a/site/dev/testing/tests.md
+++ b/site/dev/testing/tests.md
@@ -78,12 +78,12 @@ Writing a Rendering Test
ninja -C out/Debug dm
out/Debug/dm --match newgmtest
-4. Run the GM inside SampleApp:
+4. Run the GM inside Viewer:
<!--?prettify lang=sh?-->
- ninja -C out/Debug SampleApp
- out/Debug/SampleApp --slide GM:newgmtest
+ ninja -C out/Debug viewer
+ out/Debug/viewer --slide GM_newgmtest
<span id="bench"></span>