diff options
| author |  Florin Malita <fmalita@chromium.org> | 2018-07-10 11:56:29 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-07-10 19:53:36 +0000 |
| commit | 7f8a073fae1fae28081ee5218f6c690e20032d2e (patch) | |
| tree | b037847007efb53c924b8b97c72d9789926bfb75 /modules | |
| parent | 25d05f55bc85b4fd664d418d131f6ca40dc4991c (diff) | |
[skottie] Fix spurious gradient error messages
The adapter apply() method can get called before stops resolution, so
only log when some stops are present.
TBR=
Change-Id: I8e336e2cff781a0e64de31e6b63f3cf373b2daa0
Reviewed-on: https://skia-review.googlesource.com/140245
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Diffstat (limited to 'modules')
| -rw-r--r-- | modules/skottie/src/SkottieAdapter.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/modules/skottie/src/SkottieAdapter.cpp b/modules/skottie/src/SkottieAdapter.cpp index 615390e0b2..f4bb0a8fbb 100644 --- a/modules/skottie/src/SkottieAdapter.cpp +++ b/modules/skottie/src/SkottieAdapter.cpp @@ -94,7 +94,10 @@ void GradientAdapter::apply() { // |fColorStops| holds |fStopCount| x [ pos, r, g, g ] + ? x [ pos, alpha ] if (fColorStops.size() < fStopCount * 4 || ((fColorStops.size() - fStopCount * 4) % 2)) { - SkDebugf("!! Invalid gradient stop array size: %zu", fColorStops.size()); + // apply() may get called before the stops are set, so only log when we have some stops. + if (!fColorStops.empty()) { + SkDebugf("!! Invalid gradient stop array size: %zu\n", fColorStops.size()); + } return; } |