From 7f8a073fae1fae28081ee5218f6c690e20032d2e Mon Sep 17 00:00:00 2001 From: Florin Malita Date: Tue, 10 Jul 2018 11:56:29 -0400 Subject: [skottie] Fix spurious gradient error messages The adapter apply() method can get called before stops resolution, so only log when some stops are present. TBR= Change-Id: I8e336e2cff781a0e64de31e6b63f3cf373b2daa0 Reviewed-on: https://skia-review.googlesource.com/140245 Reviewed-by: Florin Malita Commit-Queue: Florin Malita --- modules/skottie/src/SkottieAdapter.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'modules') diff --git a/modules/skottie/src/SkottieAdapter.cpp b/modules/skottie/src/SkottieAdapter.cpp index 615390e0b2..f4bb0a8fbb 100644 --- a/modules/skottie/src/SkottieAdapter.cpp +++ b/modules/skottie/src/SkottieAdapter.cpp @@ -94,7 +94,10 @@ void GradientAdapter::apply() { // |fColorStops| holds |fStopCount| x [ pos, r, g, g ] + ? x [ pos, alpha ] if (fColorStops.size() < fStopCount * 4 || ((fColorStops.size() - fStopCount * 4) % 2)) { - SkDebugf("!! Invalid gradient stop array size: %zu", fColorStops.size()); + // apply() may get called before the stops are set, so only log when we have some stops. + if (!fColorStops.empty()) { + SkDebugf("!! Invalid gradient stop array size: %zu\n", fColorStops.size()); + } return; } -- cgit v1.2.3