diff options
author | kkinnunen <kkinnunen@nvidia.com> | 2016-01-18 00:47:14 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-01-18 00:47:14 -0800 |
commit | 3ca73360493ba71831c86c8c5f9c36187c0355ca (patch) | |
tree | 556c3175b5cc226fa9f3fa25336cc529078cc028 /include/views | |
parent | ab11c3f14cf829512460a627f5928c96f6fb3a97 (diff) |
SampleApp: remove SkWindow::onPDFSaved, it does not work
Remove SkWindow::onPDFSaved, it does not work and it is not used anymore.
Also, it is very SampleApp -specific feature implemented in SkWindow class.
SkWindow class is probably intended to be more app-agnosting than
what this method implies.
Presumably the idea of the callback was to inform the user of
SampleApp that the PDF was saved to a certain location.
For Android SampleApp, show a hardcoded toast that the PDF was saved to
/sdcard.
BUG=skia:4733
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1547923002
Review URL: https://codereview.chromium.org/1547923002
Diffstat (limited to 'include/views')
-rw-r--r-- | include/views/SkOSWindow_Android.h | 2 | ||||
-rw-r--r-- | include/views/SkWindow.h | 3 |
2 files changed, 0 insertions, 5 deletions
diff --git a/include/views/SkOSWindow_Android.h b/include/views/SkOSWindow_Android.h index 09163fc1cb..4fc32ce19d 100644 --- a/include/views/SkOSWindow_Android.h +++ b/include/views/SkOSWindow_Android.h @@ -36,8 +36,6 @@ public: void setVsync(bool); bool destroyRequested() { return fDestroyRequested; } - virtual void onPDFSaved(const char title[], const char desc[], const char path[]); - protected: // overrides from SkWindow virtual void onHandleInval(const SkIRect&); diff --git a/include/views/SkWindow.h b/include/views/SkWindow.h index f56c27c022..0d47875bf7 100644 --- a/include/views/SkWindow.h +++ b/include/views/SkWindow.h @@ -72,9 +72,6 @@ public: virtual SkSurface* createSurface(); - virtual void onPDFSaved(const char title[], const char desc[], - const char path[]) {} - protected: virtual bool onEvent(const SkEvent&); virtual bool onDispatchClick(int x, int y, Click::State, void* owner, unsigned modi); |