From 3ca73360493ba71831c86c8c5f9c36187c0355ca Mon Sep 17 00:00:00 2001 From: kkinnunen Date: Mon, 18 Jan 2016 00:47:14 -0800 Subject: SampleApp: remove SkWindow::onPDFSaved, it does not work Remove SkWindow::onPDFSaved, it does not work and it is not used anymore. Also, it is very SampleApp -specific feature implemented in SkWindow class. SkWindow class is probably intended to be more app-agnosting than what this method implies. Presumably the idea of the callback was to inform the user of SampleApp that the PDF was saved to a certain location. For Android SampleApp, show a hardcoded toast that the PDF was saved to /sdcard. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1547923002 Review URL: https://codereview.chromium.org/1547923002 --- include/views/SkOSWindow_Android.h | 2 -- include/views/SkWindow.h | 3 --- 2 files changed, 5 deletions(-) (limited to 'include/views') diff --git a/include/views/SkOSWindow_Android.h b/include/views/SkOSWindow_Android.h index 09163fc1cb..4fc32ce19d 100644 --- a/include/views/SkOSWindow_Android.h +++ b/include/views/SkOSWindow_Android.h @@ -36,8 +36,6 @@ public: void setVsync(bool); bool destroyRequested() { return fDestroyRequested; } - virtual void onPDFSaved(const char title[], const char desc[], const char path[]); - protected: // overrides from SkWindow virtual void onHandleInval(const SkIRect&); diff --git a/include/views/SkWindow.h b/include/views/SkWindow.h index f56c27c022..0d47875bf7 100644 --- a/include/views/SkWindow.h +++ b/include/views/SkWindow.h @@ -72,9 +72,6 @@ public: virtual SkSurface* createSurface(); - virtual void onPDFSaved(const char title[], const char desc[], - const char path[]) {} - protected: virtual bool onEvent(const SkEvent&); virtual bool onDispatchClick(int x, int y, Click::State, void* owner, unsigned modi); -- cgit v1.2.3