diff options
| author |  robertphillips <robertphillips@google.com> | 2014-07-11 06:45:58 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-07-11 06:45:58 -0700 |
| commit | ffc75efc1a4c231286c773ff090ec84fc16e9422 (patch) | |
| tree | f11bbdd03f9150d7112567d82c8ecfa4d189a169 /include/core/SkPicture.h | |
| parent | 134ae830126c01d19e254a1fee460815a05334f2 (diff) | |
Revert of Add alternate SkPicture::clone (https://codereview.chromium.org/381193002/)
Reason for revert:
Going to try to just remove the many-at-once clone interface
Original issue's description:
> Add alternate SkPicture::clone
>
> This adds an alternate version of SkPicture::clone for two reasons:
>
> 1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor)
>
> 2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely.
>
> Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/)
>
> Committed: https://skia.googlesource.com/skia/+/e372e78223a8ce916d276d6e0420d552fb0267e9
R=mtklein@google.com, reed@google.com
TBR=mtklein@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/386933004
Diffstat (limited to 'include/core/SkPicture.h')
| -rw-r--r-- | include/core/SkPicture.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h index 1bf3171496..ca26eb4496 100644 --- a/include/core/SkPicture.h +++ b/include/core/SkPicture.h @@ -123,7 +123,6 @@ public: * SkPictures. */ void clone(SkPicture* pictures, int count) const; - void clone(SkPicture* pictures[], int count) const; #endif /** Replays the drawing commands on the specified canvas. |