diff options
author | Greg Daniel <egdaniel@google.com> | 2017-05-17 19:00:40 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-05-17 19:00:51 +0000 |
commit | 89eb148abdadae49a8500ba0aafcb6740de2646d (patch) | |
tree | 83de66a6d2856795d9e15c0176ed07ff24aede4f /gn | |
parent | 154ce91dc96187229d0bc84cf10a77f480194e6f (diff) |
Revert "Add GM to verify that drawX == (path.addX, drawPath)"
This reverts commit 78d1b428a8e8a0b76e88e9266d2893136acd5906.
Reason for revert: break preabandongpu bot
Original change's description:
> Add GM to verify that drawX == (path.addX, drawPath)
>
> This demonstrates a new kind of hybrid unit test/GM.
> It creates a grid of cells. In each cell, we do two
> renders that are expected to produce the same result.
> For each cell, we render the two results overlaid,
> and highlight any differing pixels in red. Assuming
> there is a diff, the area around the largest diff
> is drawn zoomed in from both images.
>
> Matching cells are outlined in green, failing cells
> are outlined in red. Triaging this GM just involves
> answering the question: "Are there any red boxes?"
>
> "Good" example: https://screenshot.googleplex.com/909P3tvS55f.png
> "Bad" example: https://screenshot.googleplex.com/oXBWbEKw5ur.png
>
> To get more tests to pass, (and fix an assert
> in Ganesh), I've gone ahead and enforced that user
> supplied rects (in drawRect and drawOval) are
> always sorted once they hit the canvas virtuals.
> Currently, drawArc rejects empty ovals, but I added
> the same assert to onDrawArc, if we decide to change
> the strategy there.
>
> Bug: skia:
> Change-Id: I021a18c85e234298e1d29f333662683d996dd42c
> Reviewed-on: https://skia-review.googlesource.com/16983
> Commit-Queue: Brian Osman <brianosman@google.com>
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Reviewed-by: Mike Reed <reed@google.com>
>
TBR=mtklein@chromium.org,mtklein@google.com,brianosman@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: skia:
Change-Id: Id1ead4e22115c49cad5d0adb6151ede81734b4d3
Reviewed-on: https://skia-review.googlesource.com/17269
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>
Diffstat (limited to 'gn')
-rw-r--r-- | gn/gm.gni | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -259,7 +259,6 @@ gm_sources = [ "$_gm/shadowutils.cpp", "$_gm/shallowgradient.cpp", "$_gm/shapes.cpp", - "$_gm/shapes_as_paths.cpp", "$_gm/showmiplevels.cpp", "$_gm/simpleaaclip.cpp", "$_gm/simple_magnification.cpp", |