diff options
| author |  Mike Klein <mtklein@chromium.org> | 2018-03-21 13:07:35 -0400 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-03-21 19:40:00 +0000 |
| commit | 4d4b3aaa20e1978390c572a49dfcd59a0975c32f (patch) | |
| tree | 965c93a5dc3e7a74346289041ea7600146795027 /gn/BUILD.gn | |
| parent | 42409c2efacd6de4ae504fe8946ff76d6cbeebcc (diff) | |
small ABI + narrow/wide code updates
The only tangible effect this CL should have is to use __vectorcall on
all Windows builds, including scalar ones. The code generation is a
little better there with __vectorcall than not, so might as well. This
is a baby step towards vector stages with MSVC, but a very baby step
indeed.
Mostly this refactors and regroups a bunch of logic to reflect my
current thoughts. The BUILD.gn changes are essentially no-ops, but they
simplify things and make our flags more similar to how those targets are
built in Chromium.
(And I cleaned up other /arch: uses so this works.)
Change-Id: I73dd39d15cdc7b3d268231a707952bbbfd91496e
Reviewed-on: https://skia-review.googlesource.com/115644
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'gn/BUILD.gn')
| -rw-r--r-- | gn/BUILD.gn | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/gn/BUILD.gn b/gn/BUILD.gn index 8b4f953763..e7fffa2ab9 100644 --- a/gn/BUILD.gn +++ b/gn/BUILD.gn @@ -112,9 +112,7 @@ config("default") { "-mfpu=neon", "-mthumb", ] - } else if (current_cpu == "x86" && is_win) { - cflags += [ "/arch:SSE2" ] - } else if (current_cpu == "x86") { + } else if (current_cpu == "x86" && !is_win) { asmflags += [ "-m32" ] cflags += [ "-m32", |