From 4d4b3aaa20e1978390c572a49dfcd59a0975c32f Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Wed, 21 Mar 2018 13:07:35 -0400 Subject: small ABI + narrow/wide code updates The only tangible effect this CL should have is to use __vectorcall on all Windows builds, including scalar ones. The code generation is a little better there with __vectorcall than not, so might as well. This is a baby step towards vector stages with MSVC, but a very baby step indeed. Mostly this refactors and regroups a bunch of logic to reflect my current thoughts. The BUILD.gn changes are essentially no-ops, but they simplify things and make our flags more similar to how those targets are built in Chromium. (And I cleaned up other /arch: uses so this works.) Change-Id: I73dd39d15cdc7b3d268231a707952bbbfd91496e Reviewed-on: https://skia-review.googlesource.com/115644 Reviewed-by: Herb Derby Commit-Queue: Mike Klein --- gn/BUILD.gn | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'gn/BUILD.gn') diff --git a/gn/BUILD.gn b/gn/BUILD.gn index 8b4f953763..e7fffa2ab9 100644 --- a/gn/BUILD.gn +++ b/gn/BUILD.gn @@ -112,9 +112,7 @@ config("default") { "-mfpu=neon", "-mthumb", ] - } else if (current_cpu == "x86" && is_win) { - cflags += [ "/arch:SSE2" ] - } else if (current_cpu == "x86") { + } else if (current_cpu == "x86" && !is_win) { asmflags += [ "-m32" ] cflags += [ "-m32", -- cgit v1.2.3