diff options
| author |  commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-15 15:48:36 +0000 |
|---|---|---|
| committer | commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> | 2014-04-15 15:48:36 +0000 |
| commit | 73cb15351f33459e0c861a96135c634dec77ef9d (patch) | |
| tree | cf521a48286c5cd88354056e65a933cc63f8fbe1 /bench/RectoriBench.cpp | |
| parent | beb8b3a4da83ce30e313e72ae0e444870acecb7e (diff) | |
Make sure SkDrawLooper objects can only be allocated on the heap.
Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public.
Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is
used to create new objects.
Provide factory method for creating SkBlurDrawLooper.
BUG=2141
R=scroggo@google.com, reed@google.com, djsollen@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/232913003
git-svn-id: http://skia.googlecode.com/svn/trunk@14200 2bbb7eff-a529-9590-31e7-b0007b416f81
Diffstat (limited to 'bench/RectoriBench.cpp')
| -rw-r--r-- | bench/RectoriBench.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/bench/RectoriBench.cpp b/bench/RectoriBench.cpp index ee79ca9964..87f5feef89 100644 --- a/bench/RectoriBench.cpp +++ b/bench/RectoriBench.cpp @@ -71,7 +71,7 @@ private: }; SkLayerDrawLooper* createLooper(SkScalar xOff, SkScalar sigma) { - SkLayerDrawLooper* looper = new SkLayerDrawLooper; + SkLayerDrawLooper::Builder looperBuilder; //----------------------------------------------- SkLayerDrawLooper::LayerInfo info; @@ -83,7 +83,7 @@ private: info.fOffset.set(xOff, 0); info.fPostTranslate = false; - SkPaint* paint = looper->addLayer(info); + SkPaint* paint = looperBuilder.addLayer(info); SkMaskFilter* mf = SkBlurMaskFilter::Create(SkBlurMaskFilter::kNormal_BlurStyle, sigma, @@ -94,8 +94,8 @@ private: info.fPaintBits = 0; info.fOffset.set(0, 0); - paint = looper->addLayer(info); - return looper; + paint = looperBuilder.addLayer(info); + return looperBuilder.detachLooper(); } typedef SkBenchmark INHERITED; |