From 73cb15351f33459e0c861a96135c634dec77ef9d Mon Sep 17 00:00:00 2001 From: "commit-bot@chromium.org" Date: Tue, 15 Apr 2014 15:48:36 +0000 Subject: Make sure SkDrawLooper objects can only be allocated on the heap. Make constructors of SkLayerDrawLooper and SkBlurDrawLooper non-public. Remove addLayer* methods from SkLayerDrawLooper. SkLayerDrawLooper::Builder is used to create new objects. Provide factory method for creating SkBlurDrawLooper. BUG=2141 R=scroggo@google.com, reed@google.com, djsollen@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/232913003 git-svn-id: http://skia.googlecode.com/svn/trunk@14200 2bbb7eff-a529-9590-31e7-b0007b416f81 --- bench/RectoriBench.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'bench/RectoriBench.cpp') diff --git a/bench/RectoriBench.cpp b/bench/RectoriBench.cpp index ee79ca9964..87f5feef89 100644 --- a/bench/RectoriBench.cpp +++ b/bench/RectoriBench.cpp @@ -71,7 +71,7 @@ private: }; SkLayerDrawLooper* createLooper(SkScalar xOff, SkScalar sigma) { - SkLayerDrawLooper* looper = new SkLayerDrawLooper; + SkLayerDrawLooper::Builder looperBuilder; //----------------------------------------------- SkLayerDrawLooper::LayerInfo info; @@ -83,7 +83,7 @@ private: info.fOffset.set(xOff, 0); info.fPostTranslate = false; - SkPaint* paint = looper->addLayer(info); + SkPaint* paint = looperBuilder.addLayer(info); SkMaskFilter* mf = SkBlurMaskFilter::Create(SkBlurMaskFilter::kNormal_BlurStyle, sigma, @@ -94,8 +94,8 @@ private: info.fPaintBits = 0; info.fOffset.set(0, 0); - paint = looper->addLayer(info); - return looper; + paint = looperBuilder.addLayer(info); + return looperBuilder.detachLooper(); } typedef SkBenchmark INHERITED; -- cgit v1.2.3