diff options
| author |  Herb Derby <herb@google.com> | 2017-12-18 15:06:29 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-12-18 20:49:02 +0000 |
| commit | 4fafedd33add9948db1147c60d681ed9340984fd (patch) | |
| tree | c2a9f3000375c8b7c226072f67b371d0dec10b0c | |
| parent | 45fd995b9652a8ba2e0b0cad480ca08763bda7e3 (diff) | |
Make unit test tickle msan bug.
Tested using MSAN with image clearing code
removed.
Change-Id: Ic863328c868887455bb92650d3fdcecbf4d2b1cf
Reviewed-on: https://skia-review.googlesource.com/86761
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
| -rw-r--r-- | gm/imagefiltersbase.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/gm/imagefiltersbase.cpp b/gm/imagefiltersbase.cpp index da26d97d51..7fe9aff800 100644 --- a/gm/imagefiltersbase.cpp +++ b/gm/imagefiltersbase.cpp @@ -208,7 +208,10 @@ protected: IdentityImageFilter::Make(nullptr), FailImageFilter::Make(), SkColorFilterImageFilter::Make(std::move(cf), nullptr), - SkBlurImageFilter::Make(12.0f, 0.0f, nullptr), + // The strage 0.29 value tickles an edge case where crop rect calculates + // a small border, but the blur really needs no border. This tickels + // an msan uninitialized value bug. + SkBlurImageFilter::Make(12.0f, 0.29f, nullptr), SkDropShadowImageFilter::Make( 10.0f, 5.0f, 3.0f, 3.0f, SK_ColorBLUE, SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode, |