From 4fafedd33add9948db1147c60d681ed9340984fd Mon Sep 17 00:00:00 2001 From: Herb Derby Date: Mon, 18 Dec 2017 15:06:29 -0500 Subject: Make unit test tickle msan bug. Tested using MSAN with image clearing code removed. Change-Id: Ic863328c868887455bb92650d3fdcecbf4d2b1cf Reviewed-on: https://skia-review.googlesource.com/86761 Commit-Queue: Herb Derby Commit-Queue: Mike Klein Reviewed-by: Mike Klein --- gm/imagefiltersbase.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gm/imagefiltersbase.cpp b/gm/imagefiltersbase.cpp index da26d97d51..7fe9aff800 100644 --- a/gm/imagefiltersbase.cpp +++ b/gm/imagefiltersbase.cpp @@ -208,7 +208,10 @@ protected: IdentityImageFilter::Make(nullptr), FailImageFilter::Make(), SkColorFilterImageFilter::Make(std::move(cf), nullptr), - SkBlurImageFilter::Make(12.0f, 0.0f, nullptr), + // The strage 0.29 value tickles an edge case where crop rect calculates + // a small border, but the blur really needs no border. This tickels + // an msan uninitialized value bug. + SkBlurImageFilter::Make(12.0f, 0.29f, nullptr), SkDropShadowImageFilter::Make( 10.0f, 5.0f, 3.0f, 3.0f, SK_ColorBLUE, SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode, -- cgit v1.2.3