aboutsummaryrefslogtreecommitdiffhomepage
path: root/conformance
diff options
context:
space:
mode:
authorGravatar Josh Haberman <jhaberman@gmail.com>2017-03-16 15:19:09 -0700
committerGravatar Josh Haberman <jhaberman@gmail.com>2017-03-16 15:19:09 -0700
commit1b0db1cb83f09794632e8c24a1d0d1f0ca5b2365 (patch)
tree81872f6c1b9a7dd1d7d0c450c7bbe6c015cc5ffb /conformance
parent95b4427d391c5e4040e5818ff5f0384873d99412 (diff)
Removed obsolete comments and added docs.
Diffstat (limited to 'conformance')
-rw-r--r--conformance/README.md32
-rwxr-xr-xconformance/conformance_nodejs.js3
2 files changed, 30 insertions, 5 deletions
diff --git a/conformance/README.md b/conformance/README.md
index 9388055f..971fe8f6 100644
--- a/conformance/README.md
+++ b/conformance/README.md
@@ -19,11 +19,39 @@ directory to build `protoc`, since all the tests depend on it.
$ make
-Then to run the tests against the C++ implementation, run:
+Running the tests for C++
+-------------------------
+
+To run the tests against the C++ implementation, run:
$ cd conformance && make test_cpp
-More tests and languages will be added soon!
+Running the tests for JavaScript (Node.js)
+------------------------------------------
+
+To run the JavaScript tests against Node.js, make sure you have "node"
+on your path and then run:
+
+ $ cd conformance && make test_nodejs
+
+Running the tests for Ruby (MRI)
+--------------------------------
+
+To run the Ruby tests against MRI, first build the C extension:
+
+ $ cd ruby && rake
+
+Then run the tests like so:
+
+ $ cd conformance && make test_ruby
+
+Running the tests for other languages
+-------------------------------------
+
+Most of the languages in the Protobuf source tree are set up to run
+conformance tests. However some of them are more tricky to set up
+properly. See `tests.sh` in the base of the repository to see how
+Travis runs the tests.
Testing other Protocol Buffer implementations
---------------------------------------------
diff --git a/conformance/conformance_nodejs.js b/conformance/conformance_nodejs.js
index 21f516bc..5ee37269 100755
--- a/conformance/conformance_nodejs.js
+++ b/conformance/conformance_nodejs.js
@@ -101,11 +101,9 @@ function onEof(totalRead) {
function readBuffer(bytes) {
var buf = new Buffer(bytes);
var totalRead = 0;
- //console.warn("Want to read: " + bytes);
while (totalRead < bytes) {
var read = 0;
try {
- //console.warn("Trying to read: " + (bytes - totalRead));
read = fs.readSync(process.stdin.fd, buf, totalRead, bytes - totalRead);
} catch (e) {
if (e.code == 'EOF') {
@@ -116,7 +114,6 @@ function readBuffer(bytes) {
}
}
- //console.warn("Read: " + read);
totalRead += read;
}