From 1b0db1cb83f09794632e8c24a1d0d1f0ca5b2365 Mon Sep 17 00:00:00 2001 From: Josh Haberman Date: Thu, 16 Mar 2017 15:19:09 -0700 Subject: Removed obsolete comments and added docs. --- conformance/README.md | 32 ++++++++++++++++++++++++++++++-- conformance/conformance_nodejs.js | 3 --- 2 files changed, 30 insertions(+), 5 deletions(-) (limited to 'conformance') diff --git a/conformance/README.md b/conformance/README.md index 9388055f..971fe8f6 100644 --- a/conformance/README.md +++ b/conformance/README.md @@ -19,11 +19,39 @@ directory to build `protoc`, since all the tests depend on it. $ make -Then to run the tests against the C++ implementation, run: +Running the tests for C++ +------------------------- + +To run the tests against the C++ implementation, run: $ cd conformance && make test_cpp -More tests and languages will be added soon! +Running the tests for JavaScript (Node.js) +------------------------------------------ + +To run the JavaScript tests against Node.js, make sure you have "node" +on your path and then run: + + $ cd conformance && make test_nodejs + +Running the tests for Ruby (MRI) +-------------------------------- + +To run the Ruby tests against MRI, first build the C extension: + + $ cd ruby && rake + +Then run the tests like so: + + $ cd conformance && make test_ruby + +Running the tests for other languages +------------------------------------- + +Most of the languages in the Protobuf source tree are set up to run +conformance tests. However some of them are more tricky to set up +properly. See `tests.sh` in the base of the repository to see how +Travis runs the tests. Testing other Protocol Buffer implementations --------------------------------------------- diff --git a/conformance/conformance_nodejs.js b/conformance/conformance_nodejs.js index 21f516bc..5ee37269 100755 --- a/conformance/conformance_nodejs.js +++ b/conformance/conformance_nodejs.js @@ -101,11 +101,9 @@ function onEof(totalRead) { function readBuffer(bytes) { var buf = new Buffer(bytes); var totalRead = 0; - //console.warn("Want to read: " + bytes); while (totalRead < bytes) { var read = 0; try { - //console.warn("Trying to read: " + (bytes - totalRead)); read = fs.readSync(process.stdin.fd, buf, totalRead, bytes - totalRead); } catch (e) { if (e.code == 'EOF') { @@ -116,7 +114,6 @@ function readBuffer(bytes) { } } - //console.warn("Read: " + read); totalRead += read; } -- cgit v1.2.3