aboutsummaryrefslogtreecommitdiffhomepage
path: root/tag-util.c
diff options
context:
space:
mode:
authorGravatar Austin Clements <amdragon@MIT.EDU>2013-01-06 15:22:41 -0500
committerGravatar David Bremner <bremner@debian.org>2013-01-06 22:40:32 -0400
commit425e2bc81263230df301c67d93c64ff9685ff840 (patch)
tree2c9dc32b233d80b805148bb3d438b27bdd70c606 /tag-util.c
parentd08c714b6a172cf0018bee4f60aff069d5508d4e (diff)
dump/restore: Use Xapian queries for batch-tag format
This switches the new batch-tag format away from using a home-grown hex-encoding scheme for message IDs in the dump to simply using Xapian queries with Xapian quoting syntax. This has a variety of advantages beyond presenting a cleaner and more consistent interface. Foremost is that it will dramatically simplify the quoting for batch tagging, which shares the same input format. While the hex-encoding is no better or worse for the simple ID queries used by dump/restore, it becomes onerous for general-purpose queries used in batch tagging. It also better handles strange cases like "id:foo and bar", since this is no longer syntactically valid.
Diffstat (limited to 'tag-util.c')
-rw-r--r--tag-util.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/tag-util.c b/tag-util.c
index 17d7ac2f..ca12b3b1 100644
--- a/tag-util.c
+++ b/tag-util.c
@@ -124,12 +124,6 @@ parse_tag_line (void *ctx, char *line,
}
/* tok now points to the query string */
- if (hex_decode_inplace (tok) != HEX_SUCCESS) {
- ret = line_error (TAG_PARSE_INVALID, line_for_error,
- "hex decoding of query %s failed", tok);
- goto DONE;
- }
-
*query_string = tok;
DONE: