diff options
| -rw-r--r-- | ChangeLog | 25 | ||||
| -rw-r--r-- | include/fuse_lowlevel.h | 8 | ||||
| -rw-r--r-- | kernel/dev.c | 2 | ||||
| -rw-r--r-- | kernel/dir.c | 199 | ||||
| -rw-r--r-- | kernel/file.c | 16 | ||||
| -rw-r--r-- | kernel/fuse_i.h | 3 | ||||
| -rw-r--r-- | kernel/fuse_kernel.h | 13 | ||||
| -rw-r--r-- | kernel/inode.c | 5 | ||||
| -rw-r--r-- | lib/fuse.c | 16 | ||||
| -rw-r--r-- | lib/fuse_lowlevel.c | 41 |
10 files changed, 203 insertions, 125 deletions
@@ -3,7 +3,30 @@ * Block TERM, INT, HUP and QUIT signals in all but the main thread. According to POSIX it's not specified which thread will receive these signals. - + + * Kernel changes: + + * Check for directory aliasing on mkdir, not just on lookup + + * Check for special node ID values in create+open operation + + * Sync with -mm: readv, writev, aio_read and aio_write methods + added to file operations + + * Cleanups: lookup code, page offset calculation + + * ABI stepped to 7.4, changes: + + * frsize member added to fuse_kstatfs structure + + * added support for negative entry caching: on lowlevel API if + fuse_entry_param::ino is set to zero in reply to a lookup request, + the kernel will cache the dentry for the specified amount of time. + + * libfuse: added 'negative_timeout' option: specifies how much + negative entries should be cached. Default is zero, to be + compatible with prior versions. + 2005-11-22 Miklos Szeredi <miklos@szeredi.hu> * Add detection of mainline FUSE code in running kernel diff --git a/include/fuse_lowlevel.h b/include/fuse_lowlevel.h index a88a898..74c483c 100644 --- a/include/fuse_lowlevel.h +++ b/include/fuse_lowlevel.h @@ -63,7 +63,13 @@ struct fuse_chan; /** Directory entry parameters supplied to fuse_reply_entry() */ struct fuse_entry_param { - /** Unique inode number */ + /** Unique inode number + * + * In lookup, zero means negative entry (from version 2.5) + * Returning ENOENT also means negative entry, but by setting zero + * ino the kernel may cache negative entries for entry_timeout + * seconds. + */ fuse_ino_t ino; /** The ino/generation pair should be unique for the filesystem's diff --git a/kernel/dev.c b/kernel/dev.c index 30bed76..d5fb2b6 100644 --- a/kernel/dev.c +++ b/kernel/dev.c @@ -218,6 +218,8 @@ static void request_end(struct fuse_conn *fc, struct fuse_req *req) if (req->misc.init_in_out.major != FUSE_KERNEL_VERSION) fc->conn_error = 1; + fc->minor = req->misc.init_in_out.minor; + /* After INIT reply is received other requests can go out. So do (FUSE_MAX_OUTSTANDING - 1) number of up()s on outstanding_sem. The last up() is done in diff --git a/kernel/dir.c b/kernel/dir.c index bfec288..63cc944 100644 --- a/kernel/dir.c +++ b/kernel/dir.c @@ -27,6 +27,30 @@ static inline unsigned long time_to_jiffies(unsigned long sec, return jiffies + timespec_to_jiffies(&ts); } +static void fuse_change_timeout(struct dentry *entry, struct fuse_entry_out *o) +{ + entry->d_time = time_to_jiffies(o->entry_valid, o->entry_valid_nsec); + if (entry->d_inode) + get_fuse_inode(entry->d_inode)->i_time = + time_to_jiffies(o->attr_valid, o->attr_valid_nsec); +} + +void fuse_invalidate_attr(struct inode *inode) +{ + get_fuse_inode(inode)->i_time = jiffies - 1; +} + +static void fuse_invalidate_entry_cache(struct dentry *entry) +{ + entry->d_time = jiffies - 1; +} + +static void fuse_invalidate_entry(struct dentry *entry) +{ + d_invalidate(entry); + fuse_invalidate_entry_cache(entry); +} + static void fuse_lookup_init(struct fuse_req *req, struct inode *dir, struct dentry *entry, struct fuse_entry_out *outarg) @@ -44,15 +68,22 @@ static void fuse_lookup_init(struct fuse_req *req, struct inode *dir, static int fuse_dentry_revalidate(struct dentry *entry, struct nameidata *nd) { - if (!entry->d_inode || is_bad_inode(entry->d_inode)) + struct inode *inode = entry->d_inode; + + if (inode && is_bad_inode(inode)) return 0; else if (time_after(jiffies, entry->d_time)) { int err; struct fuse_entry_out outarg; - struct inode *inode = entry->d_inode; - struct fuse_inode *fi = get_fuse_inode(inode); - struct fuse_conn *fc = get_fuse_conn(inode); - struct fuse_req *req = fuse_get_request(fc); + struct fuse_conn *fc; + struct fuse_req *req; + + fuse_invalidate_entry_cache(entry); + if (!inode) + return 0; + + fc = get_fuse_conn(inode); + req = fuse_get_request(fc); if (!req) return 0; @@ -60,6 +91,7 @@ static int fuse_dentry_revalidate(struct dentry *entry, struct nameidata *nd) request_send(fc, req); err = req->out.h.error; if (!err) { + struct fuse_inode *fi = get_fuse_inode(inode); if (outarg.nodeid != get_node_id(inode)) { fuse_send_forget(fc, req, outarg.nodeid, 1); return 0; @@ -71,13 +103,36 @@ static int fuse_dentry_revalidate(struct dentry *entry, struct nameidata *nd) return 0; fuse_change_attributes(inode, &outarg.attr); - entry->d_time = time_to_jiffies(outarg.entry_valid, - outarg.entry_valid_nsec); - fi->i_time = time_to_jiffies(outarg.attr_valid, - outarg.attr_valid_nsec); + fuse_change_timeout(entry, &outarg); } return 1; } + +static int dir_alias(struct inode *inode) +{ + if (S_ISDIR(inode->i_mode)) { + /* Don't allow creating an alias to a directory */ + struct dentry *alias = d_find_alias(inode); +#if defined(FUSE_MAINLINE) || !defined(KERNEL_2_6) + if (alias) { + dput(alias); + return 1; + } +#else + if (alias && !(alias->d_flags & DCACHE_DISCONNECTED)) { + dput(alias); + return 1; + } + dput(alias); +#endif + } + return 0; +} + +static inline int invalid_nodeid(u64 nodeid) +{ + return !nodeid || nodeid == FUSE_ROOT_ID; +} #ifndef KERNEL_2_6 static int fuse_dentry_revalidate_2_4(struct dentry *entry, int flags) { @@ -93,61 +148,62 @@ static struct dentry_operations fuse_dentry_operations = { #endif }; -static int fuse_lookup_iget(struct inode *dir, struct dentry *entry, - struct inode **inodep) +static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, + struct nameidata *nd) { int err; struct fuse_entry_out outarg; struct inode *inode = NULL; struct fuse_conn *fc = get_fuse_conn(dir); struct fuse_req *req; +#if !defined(FUSE_MAINLINE) && defined(KERNEL_2_6) + struct dentry *newent; +#endif if (entry->d_name.len > FUSE_NAME_MAX) - return -ENAMETOOLONG; + return ERR_PTR(-ENAMETOOLONG); req = fuse_get_request(fc); if (!req) - return -EINTR; + return ERR_PTR(-EINTR); fuse_lookup_init(req, dir, entry, &outarg); request_send(fc, req); err = req->out.h.error; - if (!err && (!outarg.nodeid || outarg.nodeid == FUSE_ROOT_ID)) + if (!err && outarg.nodeid && invalid_nodeid(outarg.nodeid)) err = -EIO; - if (!err) { + if (!err && outarg.nodeid) { inode = fuse_iget(dir->i_sb, outarg.nodeid, outarg.generation, &outarg.attr); if (!inode) { fuse_send_forget(fc, req, outarg.nodeid, 1); - return -ENOMEM; + return ERR_PTR(-ENOMEM); } } fuse_put_request(fc, req); if (err && err != -ENOENT) - return err; + return ERR_PTR(err); - if (inode) { - struct fuse_inode *fi = get_fuse_inode(inode); - entry->d_time = time_to_jiffies(outarg.entry_valid, - outarg.entry_valid_nsec); - fi->i_time = time_to_jiffies(outarg.attr_valid, - outarg.attr_valid_nsec); + if (inode && dir_alias(inode)) { + iput(inode); + return ERR_PTR(-EIO); } - +#if defined(FUSE_MAINLINE) || !defined(KERNEL_2_6) + d_add(entry, inode); +#else + newent = d_splice_alias(inode, entry); + entry = newent ? newent : entry; +#endif entry->d_op = &fuse_dentry_operations; - *inodep = inode; - return 0; -} - -void fuse_invalidate_attr(struct inode *inode) -{ - get_fuse_inode(inode)->i_time = jiffies - 1; -} - -static void fuse_invalidate_entry(struct dentry *entry) -{ - d_invalidate(entry); - entry->d_time = jiffies - 1; + if (!err) + fuse_change_timeout(entry, &outarg); + else + fuse_invalidate_entry_cache(entry); +#if defined(FUSE_MAINLINE) || !defined(KERNEL_2_6) + return NULL; +#else + return newent; +#endif } #ifdef HAVE_LOOKUP_INSTANTIATE_FILP @@ -161,7 +217,6 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry, int mode, struct fuse_open_in inarg; struct fuse_open_out outopen; struct fuse_entry_out outentry; - struct fuse_inode *fi; struct fuse_file *ff; struct file *file; int flags = nd->intent.open.flags - 1; @@ -202,6 +257,7 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry, int mode, req->out.args[1].value = &outopen; request_send(fc, req); err = req->out.h.error; + ff->fh = outopen.fh; if (err) { if (err == -ENOSYS) fc->no_create = 1; @@ -209,7 +265,7 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry, int mode, } err = -EIO; - if (!S_ISREG(outentry.attr.mode)) + if (!S_ISREG(outentry.attr.mode) || invalid_nodeid(outentry.nodeid)) goto out_free_ff; inode = fuse_iget(dir->i_sb, outentry.nodeid, outentry.generation, @@ -217,21 +273,15 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry, int mode, err = -ENOMEM; if (!inode) { flags &= ~(O_CREAT | O_EXCL | O_TRUNC); - ff->fh = outopen.fh; fuse_send_release(fc, ff, outentry.nodeid, NULL, flags, 0); goto out_put_request; } fuse_put_request(fc, req); - entry->d_time = time_to_jiffies(outentry.entry_valid, - outentry.entry_valid_nsec); - fi = get_fuse_inode(inode); - fi->i_time = time_to_jiffies(outentry.attr_valid, - outentry.attr_valid_nsec); d_instantiate(entry, inode); + fuse_change_timeout(entry, &outentry); file = lookup_instantiate_filp(nd, entry, generic_file_open); if (IS_ERR(file)) { - ff->fh = outopen.fh; fuse_send_release(fc, ff, outentry.nodeid, inode, flags, 0); return PTR_ERR(file); } @@ -253,7 +303,6 @@ static int create_new_entry(struct fuse_conn *fc, struct fuse_req *req, { struct fuse_entry_out outarg; struct inode *inode; - struct fuse_inode *fi; int err; req->in.h.nodeid = get_node_id(dir); @@ -267,7 +316,7 @@ static int create_new_entry(struct fuse_conn *fc, struct fuse_req *req, fuse_put_request(fc, req); return err; } - if (!outarg.nodeid || outarg.nodeid == FUSE_ROOT_ID) { + if (invalid_nodeid(outarg.nodeid)) { fuse_put_request(fc, req); return -EIO; } @@ -280,19 +329,13 @@ static int create_new_entry(struct fuse_conn *fc, struct fuse_req *req, fuse_put_request(fc, req); /* Don't allow userspace to do really stupid things... */ - if ((inode->i_mode ^ mode) & S_IFMT) { + if (((inode->i_mode ^ mode) & S_IFMT) || dir_alias(inode)) { iput(inode); return -EIO; } - entry->d_time = time_to_jiffies(outarg.entry_valid, - outarg.entry_valid_nsec); - - fi = get_fuse_inode(inode); - fi->i_time = time_to_jiffies(outarg.attr_valid, - outarg.attr_valid_nsec); - d_instantiate(entry, inode); + fuse_change_timeout(entry, &outarg); fuse_invalidate_attr(dir); return 0; } @@ -400,6 +443,7 @@ static int fuse_unlink(struct inode *dir, struct dentry *entry) inode->i_nlink = 0; fuse_invalidate_attr(inode); fuse_invalidate_attr(dir); + fuse_invalidate_entry_cache(entry); } else if (err == -EINTR) fuse_invalidate_entry(entry); return err; @@ -425,6 +469,7 @@ static int fuse_rmdir(struct inode *dir, struct dentry *entry) if (!err) { entry->d_inode->i_nlink = 0; fuse_invalidate_attr(dir); + fuse_invalidate_entry_cache(entry); } else if (err == -EINTR) fuse_invalidate_entry(entry); return err; @@ -460,6 +505,9 @@ static int fuse_rename(struct inode *olddir, struct dentry *oldent, fuse_invalidate_attr(olddir); if (olddir != newdir) fuse_invalidate_attr(newdir); + + /* newent will end up negative */ + fuse_invalidate_entry_cache(newent); } else if (err == -EINTR) { /* If request was interrupted, DEITY only knows if the rename actually took place. If the invalidation @@ -958,45 +1006,10 @@ static int fuse_getattr(struct vfsmount *mnt, struct dentry *entry, return err; } - -static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, - struct nameidata *nd) -{ - struct inode *inode; - int err = fuse_lookup_iget(dir, entry, &inode); - if (err) - return ERR_PTR(err); - if (inode && S_ISDIR(inode->i_mode)) { - /* Don't allow creating an alias to a directory */ - struct dentry *alias = d_find_alias(inode); - if (alias && !(alias->d_flags & DCACHE_DISCONNECTED)) { - dput(alias); - iput(inode); - return ERR_PTR(-EIO); - } - dput(alias); - } - return d_splice_alias(inode, entry); -} #else /* KERNEL_2_6 */ -static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry) +static struct dentry *fuse_lookup_2_4(struct inode *dir, struct dentry *entry) { - struct inode *inode; - struct dentry *alias; - - int err = fuse_lookup_iget(dir, entry, &inode); - if (err) - return ERR_PTR(err); - - if (inode && S_ISDIR(inode->i_mode) && - (alias = d_find_alias(inode)) != NULL) { - dput(alias); - iput(inode); - return ERR_PTR(-EIO); - } - - d_add(entry, inode); - return NULL; + return fuse_lookup(dir, entry, NULL); } static int fuse_mknod_2_4(struct inode *dir, struct dentry *entry, int mode, diff --git a/kernel/file.c b/kernel/file.c index c047c84..8187b10 100644 --- a/kernel/file.c +++ b/kernel/file.c @@ -280,7 +280,6 @@ static int fuse_readpage(struct file *file, struct page *page) { struct inode *inode = page->mapping->host; struct fuse_conn *fc = get_fuse_conn(inode); - loff_t pos = (loff_t) page->index << PAGE_CACHE_SHIFT; struct fuse_req *req = fuse_get_request(fc); int err = -EINTR; if (!req) @@ -289,7 +288,7 @@ static int fuse_readpage(struct file *file, struct page *page) req->out.page_zeroing = 1; req->num_pages = 1; req->pages[0] = page; - fuse_send_read(req, file, inode, pos, PAGE_CACHE_SIZE); + fuse_send_read(req, file, inode, page_offset(page), PAGE_CACHE_SIZE); err = req->out.h.error; fuse_put_request(fc, req); if (!err) @@ -304,7 +303,7 @@ static int fuse_readpage(struct file *file, struct page *page) static int fuse_send_readpages(struct fuse_req *req, struct file *file, struct inode *inode) { - loff_t pos = (loff_t) req->pages[0]->index << PAGE_CACHE_SHIFT; + loff_t pos = page_offset(req->pages[0]); size_t count = req->num_pages << PAGE_CACHE_SHIFT; unsigned i; req->out.page_zeroing = 1; @@ -510,7 +509,7 @@ static int fuse_commit_write(struct file *file, struct page *page, unsigned count = to - offset; struct inode *inode = page->mapping->host; struct fuse_conn *fc = get_fuse_conn(inode); - loff_t pos = ((loff_t) page->index << PAGE_CACHE_SHIFT) + offset; + loff_t pos = page_offset(page) + offset; struct fuse_req *req = fuse_get_request(fc); if (!req) return -EINTR; @@ -690,11 +689,16 @@ static int fuse_set_page_dirty(struct page *page) static struct file_operations fuse_file_operations = { .llseek = generic_file_llseek, #ifdef KERNEL_2_6 - .read = generic_file_read, + .read = do_sync_read, + .write = do_sync_write, + .readv = generic_file_readv, + .writev = generic_file_writev, + .aio_read = generic_file_aio_read, + .aio_write = generic_file_aio_write, #else .read = fuse_file_read, -#endif .write = generic_file_write, +#endif .mmap = fuse_file_mmap, .open = fuse_open, .flush = fuse_flush, diff --git a/kernel/fuse_i.h b/kernel/fuse_i.h index fbebe7f..9ae1eec 100644 --- a/kernel/fuse_i.h +++ b/kernel/fuse_i.h @@ -349,6 +349,9 @@ struct fuse_conn { /** Is create not implemented by fs? */ unsigned no_create : 1; + /** Negotiated minor version */ + unsigned minor; + #ifdef KERNEL_2_6 /** Backing dev info */ struct backing_dev_info bdi; diff --git a/kernel/fuse_kernel.h b/kernel/fuse_kernel.h index 492c5cc..b755fdb 100644 --- a/kernel/fuse_kernel.h +++ b/kernel/fuse_kernel.h @@ -6,6 +6,9 @@ See the file COPYING. */ +/* This file defines the kernel interface of FUSE */ + +#ifdef __FreeBSD__ /* This -- and only this -- header file may also be distributed under the terms of the BSD Licence as follows: @@ -34,9 +37,6 @@ SUCH DAMAGE. */ -/* This file defines the kernel interface of FUSE */ - -#ifdef __FreeBSD__ #include <sys/types.h> #define __u64 uint64_t #define __u32 uint32_t @@ -49,7 +49,7 @@ #define FUSE_KERNEL_VERSION 7 /** Minor version number of this interface */ -#define FUSE_KERNEL_MINOR_VERSION 3 +#define FUSE_KERNEL_MINOR_VERSION 4 /** The node ID of the root inode */ #define FUSE_ROOT_ID 1 @@ -88,6 +88,9 @@ struct fuse_kstatfs { __u64 ffree; __u32 bsize; __u32 namelen; + __u32 frsize; + __u32 padding; + __u32 spare[6]; }; #define FATTR_MODE (1 << 0) @@ -248,6 +251,8 @@ struct fuse_write_out { __u32 padding; }; +#define FUSE_COMPAT_STATFS_SIZE 12 + struct fuse_statfs_out { struct fuse_kstatfs st; }; diff --git a/kernel/inode.c b/kernel/inode.c index 142991c..f2d6768 100644 --- a/kernel/inode.c +++ b/kernel/inode.c @@ -290,6 +290,7 @@ static void convert_fuse_statfs(struct kstatfs *stbuf, struct fuse_kstatfs *attr { stbuf->f_type = FUSE_SUPER_MAGIC; stbuf->f_bsize = attr->bsize; + stbuf->f_frsize = attr->frsize; stbuf->f_blocks = attr->blocks; stbuf->f_bfree = attr->bfree; stbuf->f_bavail = attr->bavail; @@ -310,10 +311,12 @@ static int fuse_statfs(struct super_block *sb, struct kstatfs *buf) if (!req) return -EINTR; + memset(&outarg, 0, sizeof(outarg)); req->in.numargs = 0; req->in.h.opcode = FUSE_STATFS; req->out.numargs = 1; - req->out.args[0].size = sizeof(outarg); + req->out.args[0].size = + fc->minor < 4 ? FUSE_COMPAT_STATFS_SIZE : sizeof(outarg); req->out.args[0].value = &outarg; request_send(fc, req); err = req->out.h.error; @@ -80,6 +80,7 @@ struct fuse { unsigned int gid; unsigned int umask; double entry_timeout; + double negative_timeout; double attr_timeout; }; @@ -611,8 +612,14 @@ static void fuse_lookup(fuse_req_t req, fuse_ino_t parent, const char *name) fflush(stdout); } err = -ENOSYS; - if (f->op.getattr) + if (f->op.getattr) { err = lookup_path(f, parent, name, path, &e, NULL); + if (err == -ENOENT && f->negative_timeout != 0.0) { + e.ino = 0; + e.entry_timeout = f->negative_timeout; + err = 0; + } + } free(path); } pthread_rwlock_unlock(&f->tree_lock); @@ -1835,7 +1842,8 @@ int fuse_is_lib_option(const char *opt) begins_with(opt, "uid=") || begins_with(opt, "gid=") || begins_with(opt, "entry_timeout=") || - begins_with(opt, "attr_timeout=")) + begins_with(opt, "attr_timeout=") || + begins_with(opt, "negative_timeout=")) return 1; else return 0; @@ -1882,6 +1890,9 @@ static int parse_lib_opts(struct fuse *f, const char *opts, char **llopts) /* nop */; else if (sscanf(opt, "attr_timeout=%lf", &f->attr_timeout) == 1) /* nop */; + else if (sscanf(opt, "negative_timeout=%lf", + &f->negative_timeout) == 1) + /* nop */; else fprintf(stderr, "fuse: warning: unknown option `%s'\n", opt); } @@ -1924,6 +1935,7 @@ struct fuse *fuse_new_common(int fd, const char *opts, f->entry_timeout = 1.0; f->attr_timeout = 1.0; + f->negative_timeout = 0.0; if (parse_lib_opts(f, opts, &llopts) == -1) goto out_free; diff --git a/lib/fuse_lowlevel.c b/lib/fuse_lowlevel.c index 4e5c2ac..3cc49f0 100644 --- a/lib/fuse_lowlevel.c +++ b/lib/fuse_lowlevel.c @@ -188,6 +188,7 @@ static void convert_statfs(const struct statvfs *stbuf, struct fuse_kstatfs *kstatfs) { kstatfs->bsize = stbuf->f_bsize; + kstatfs->frsize = stbuf->f_frsize; kstatfs->blocks = stbuf->f_blocks; kstatfs->bfree = stbuf->f_bfree; kstatfs->bavail = stbuf->f_bavail; @@ -258,6 +259,11 @@ int fuse_reply_entry(fuse_req_t req, const struct fuse_entry_param *e) { struct fuse_entry_out arg; + /* before ABI 7.4 e->ino == 0 was invalid, only ENOENT meant + negative entry */ + if (!e->ino && req->f->minor < 4) + return fuse_reply_err(req, ENOENT); + memset(&arg, 0, sizeof(arg)); fill_entry(&arg, e); return send_reply_ok(req, &arg, sizeof(arg)); @@ -322,11 +328,12 @@ int fuse_reply_buf(fuse_req_t req, const char *buf, size_t size) int fuse_reply_statfs(fuse_req_t req, const struct statvfs *stbuf) { struct fuse_statfs_out arg; + size_t size = req->f->minor < 4 ? FUSE_COMPAT_STATFS_SIZE : sizeof(arg); memset(&arg, 0, sizeof(arg)); convert_statfs(stbuf, &arg.st); - return send_reply_ok(req, &arg, sizeof(arg)); + return send_reply_ok(req, &arg, size); } int fuse_reply_xattr(fuse_req_t req, size_t count) @@ -690,11 +697,11 @@ static void do_init(fuse_req_t req, struct fuse_init_in_out *arg) f->op.init(f->userdata); f->major = FUSE_KERNEL_VERSION; - f->minor = FUSE_KERNEL_MINOR_VERSION; + f->minor = arg->minor; memset(&outarg, 0, sizeof(outarg)); outarg.major = f->major; - outarg.minor = f->minor; + outarg.minor = FUSE_KERNEL_MINOR_VERSION; if (f->debug) { printf(" INIT: %u.%u\n", outarg.major, outarg.minor); @@ -976,16 +983,16 @@ static void fill_open_compat(struct fuse_open_out *arg, arg->open_flags |= FOPEN_KEEP_CACHE; } -static void convert_statfs_compat(const struct statfs *stbuf, - struct fuse_kstatfs *kstatfs) +static void convert_statfs_compat(const struct statfs *compatbuf, + struct statvfs *buf) { - kstatfs->bsize = stbuf->f_bsize; - kstatfs->blocks = stbuf->f_blocks; - kstatfs->bfree = stbuf->f_bfree; - kstatfs->bavail = stbuf->f_bavail; - kstatfs->files = stbuf->f_files; - kstatfs->ffree = stbuf->f_ffree; - kstatfs->namelen = stbuf->f_namelen; + buf->f_bsize = compatbuf->f_bsize; + buf->f_blocks = compatbuf->f_blocks; + buf->f_bfree = compatbuf->f_bfree; + buf->f_bavail = compatbuf->f_bavail; + buf->f_files = compatbuf->f_files; + buf->f_ffree = compatbuf->f_ffree; + buf->f_namemax = compatbuf->f_namelen; } int fuse_reply_open_compat(fuse_req_t req, @@ -1000,16 +1007,16 @@ int fuse_reply_open_compat(fuse_req_t req, int fuse_reply_statfs_compat(fuse_req_t req, const struct statfs *stbuf) { - struct fuse_statfs_out arg; + struct statvfs newbuf; - memset(&arg, 0, sizeof(arg)); - convert_statfs_compat(stbuf, &arg.st); + memset(&newbuf, 0, sizeof(newbuf)); + convert_statfs_compat(stbuf, &newbuf); - return send_reply_ok(req, &arg, sizeof(arg)); + return fuse_reply_statfs(req, &newbuf); } __asm__(".symver fuse_reply_statfs_compat,fuse_reply_statfs@FUSE_2.4"); __asm__(".symver fuse_reply_open_compat,fuse_reply_open@FUSE_2.4"); -#endif __FreeBSD__ +#endif /* __FreeBSD__ */ |