aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
diff options
context:
space:
mode:
authorGravatar Jan Tattermusch <jtattermusch@google.com>2018-10-23 16:18:39 +0200
committerGravatar Jan Tattermusch <jtattermusch@google.com>2018-10-23 16:18:39 +0200
commit32495f4ceecf4dbabaf86b20701a7301638da9f6 (patch)
tree9c0621023935a56cbd8addc4efee2ebd1d6cdba9 /tools
parent6b5f1143fc6d7ac95ec244e71b0995a4fcb878f1 (diff)
address review comments
Diffstat (limited to 'tools')
-rwxr-xr-xtools/internal_ci/linux/grpc_interop_matrix.sh2
-rwxr-xr-xtools/interop_matrix/run_interop_matrix_tests.py6
2 files changed, 5 insertions, 3 deletions
diff --git a/tools/internal_ci/linux/grpc_interop_matrix.sh b/tools/internal_ci/linux/grpc_interop_matrix.sh
index fea365eeff..a5220ea087 100755
--- a/tools/internal_ci/linux/grpc_interop_matrix.sh
+++ b/tools/internal_ci/linux/grpc_interop_matrix.sh
@@ -22,4 +22,4 @@ cd $(dirname $0)/../../..
source tools/internal_ci/helper_scripts/prepare_build_linux_rc
-tools/interop_matrix/run_interop_matrix_tests.py $RUN_TESTS_FLAGS \ No newline at end of file
+tools/interop_matrix/run_interop_matrix_tests.py $RUN_TESTS_FLAGS
diff --git a/tools/interop_matrix/run_interop_matrix_tests.py b/tools/interop_matrix/run_interop_matrix_tests.py
index d5388a22f7..be9edc0b9b 100755
--- a/tools/interop_matrix/run_interop_matrix_tests.py
+++ b/tools/interop_matrix/run_interop_matrix_tests.py
@@ -165,6 +165,8 @@ def _generate_test_case_jobspecs(lang, runtime, release, suite_name):
job_spec_list = []
for line in testcase_lines:
+ # TODO(jtattermusch): revisit the logic for updating test case commands
+ # what it currently being done seems fragile.
m = re.search('--test_case=(.*)"', line)
shortname = m.group(1) if m else 'unknown_test'
m = re.search('--server_host_override=(.*).sandbox.googleapis.com',
@@ -198,8 +200,8 @@ def _pull_images_for_lang(lang, images):
download_specs = []
for release, image in images:
# Pull the image and warm it up.
- # First time we use an image with "docker run", it takes time to unpack the image
- # and later this delay would fail our test cases.
+ # First time we use an image with "docker run", it takes time to unpack
+ # the image and later this delay would fail our test cases.
cmdline = [
'gcloud docker -- pull %s && docker run --rm=true %s /bin/true' %
(image, image)