From 32495f4ceecf4dbabaf86b20701a7301638da9f6 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Tue, 23 Oct 2018 16:18:39 +0200 Subject: address review comments --- tools/internal_ci/linux/grpc_interop_matrix.sh | 2 +- tools/interop_matrix/run_interop_matrix_tests.py | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'tools') diff --git a/tools/internal_ci/linux/grpc_interop_matrix.sh b/tools/internal_ci/linux/grpc_interop_matrix.sh index fea365eeff..a5220ea087 100755 --- a/tools/internal_ci/linux/grpc_interop_matrix.sh +++ b/tools/internal_ci/linux/grpc_interop_matrix.sh @@ -22,4 +22,4 @@ cd $(dirname $0)/../../.. source tools/internal_ci/helper_scripts/prepare_build_linux_rc -tools/interop_matrix/run_interop_matrix_tests.py $RUN_TESTS_FLAGS \ No newline at end of file +tools/interop_matrix/run_interop_matrix_tests.py $RUN_TESTS_FLAGS diff --git a/tools/interop_matrix/run_interop_matrix_tests.py b/tools/interop_matrix/run_interop_matrix_tests.py index d5388a22f7..be9edc0b9b 100755 --- a/tools/interop_matrix/run_interop_matrix_tests.py +++ b/tools/interop_matrix/run_interop_matrix_tests.py @@ -165,6 +165,8 @@ def _generate_test_case_jobspecs(lang, runtime, release, suite_name): job_spec_list = [] for line in testcase_lines: + # TODO(jtattermusch): revisit the logic for updating test case commands + # what it currently being done seems fragile. m = re.search('--test_case=(.*)"', line) shortname = m.group(1) if m else 'unknown_test' m = re.search('--server_host_override=(.*).sandbox.googleapis.com', @@ -198,8 +200,8 @@ def _pull_images_for_lang(lang, images): download_specs = [] for release, image in images: # Pull the image and warm it up. - # First time we use an image with "docker run", it takes time to unpack the image - # and later this delay would fail our test cases. + # First time we use an image with "docker run", it takes time to unpack + # the image and later this delay would fail our test cases. cmdline = [ 'gcloud docker -- pull %s && docker run --rm=true %s /bin/true' % (image, image) -- cgit v1.2.3