aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Yash Tibrewal <yashkt@google.com>2019-01-10 14:13:43 -0800
committerGravatar Yash Tibrewal <yashkt@google.com>2019-01-10 14:13:43 -0800
commitaa5950936923437b45dbe75f5d981033ec00a2f9 (patch)
tree6554f88f5bca92f237357d9892fa2b4013f3aba7
parentc01e866a88beee6143f19fa243b85d5792c36cae (diff)
Reviewer comments
-rw-r--r--examples/cpp/keyvaluestore/caching_interceptor.cc0
-rw-r--r--examples/cpp/keyvaluestore/client.cc3
-rw-r--r--examples/cpp/keyvaluestore/server.cc2
3 files changed, 3 insertions, 2 deletions
diff --git a/examples/cpp/keyvaluestore/caching_interceptor.cc b/examples/cpp/keyvaluestore/caching_interceptor.cc
deleted file mode 100644
index e69de29bb2..0000000000
--- a/examples/cpp/keyvaluestore/caching_interceptor.cc
+++ /dev/null
diff --git a/examples/cpp/keyvaluestore/client.cc b/examples/cpp/keyvaluestore/client.cc
index cdf353fafd..e956a16573 100644
--- a/examples/cpp/keyvaluestore/client.cc
+++ b/examples/cpp/keyvaluestore/client.cc
@@ -41,7 +41,8 @@ class KeyValueStoreClient {
KeyValueStoreClient(std::shared_ptr<Channel> channel)
: stub_(KeyValueStore::NewStub(channel)) {}
- // Requests each key in the vector and displays the value as a pair
+ // Requests each key in the vector and displays the key and its corresponding
+ // value as a pair
void GetValues(const std::vector<std::string>& keys) {
// Context for the client. It could be used to convey extra information to
// the server and/or tweak certain RPC behaviors.
diff --git a/examples/cpp/keyvaluestore/server.cc b/examples/cpp/keyvaluestore/server.cc
index 8dc8752eda..515a1ba4c9 100644
--- a/examples/cpp/keyvaluestore/server.cc
+++ b/examples/cpp/keyvaluestore/server.cc
@@ -81,7 +81,7 @@ void RunServer() {
// Listen on the given address without any authentication mechanism.
builder.AddListeningPort(server_address, grpc::InsecureServerCredentials());
// Register "service" as the instance through which we'll communicate with
- // clients. In this case it corresponds to an *synchronous* service.
+ // clients. In this case, it corresponds to an *synchronous* service.
builder.RegisterService(&service);
// Finally assemble the server.
std::unique_ptr<Server> server(builder.BuildAndStart());