From aa5950936923437b45dbe75f5d981033ec00a2f9 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Thu, 10 Jan 2019 14:13:43 -0800 Subject: Reviewer comments --- examples/cpp/keyvaluestore/caching_interceptor.cc | 0 examples/cpp/keyvaluestore/client.cc | 3 ++- examples/cpp/keyvaluestore/server.cc | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) delete mode 100644 examples/cpp/keyvaluestore/caching_interceptor.cc diff --git a/examples/cpp/keyvaluestore/caching_interceptor.cc b/examples/cpp/keyvaluestore/caching_interceptor.cc deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/examples/cpp/keyvaluestore/client.cc b/examples/cpp/keyvaluestore/client.cc index cdf353fafd..e956a16573 100644 --- a/examples/cpp/keyvaluestore/client.cc +++ b/examples/cpp/keyvaluestore/client.cc @@ -41,7 +41,8 @@ class KeyValueStoreClient { KeyValueStoreClient(std::shared_ptr channel) : stub_(KeyValueStore::NewStub(channel)) {} - // Requests each key in the vector and displays the value as a pair + // Requests each key in the vector and displays the key and its corresponding + // value as a pair void GetValues(const std::vector& keys) { // Context for the client. It could be used to convey extra information to // the server and/or tweak certain RPC behaviors. diff --git a/examples/cpp/keyvaluestore/server.cc b/examples/cpp/keyvaluestore/server.cc index 8dc8752eda..515a1ba4c9 100644 --- a/examples/cpp/keyvaluestore/server.cc +++ b/examples/cpp/keyvaluestore/server.cc @@ -81,7 +81,7 @@ void RunServer() { // Listen on the given address without any authentication mechanism. builder.AddListeningPort(server_address, grpc::InsecureServerCredentials()); // Register "service" as the instance through which we'll communicate with - // clients. In this case it corresponds to an *synchronous* service. + // clients. In this case, it corresponds to an *synchronous* service. builder.RegisterService(&service); // Finally assemble the server. std::unique_ptr server(builder.BuildAndStart()); -- cgit v1.2.3