diff options
| author |  Joey Hess <joeyh@joeyh.name> | 2017-12-08 14:49:55 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2017-12-08 14:51:17 -0400 |
| commit | febfa1d66a5cfa52d2c2f5455061f8e04d15a455 (patch) | |
| tree | 4ba9610026cd6d4524774c576fd7fb59644a0499 /doc | |
| parent | 4f0f992de990476ebd3b2be3d03a8a04a0b42243 (diff) | |
fix regression in addurl --fast caused by youtube-dl support
Similar to 9ec6bdfb526fa6b75a264b6417b24aa7f01adc25 but another code
path. As well as using youtube-dl unecessarily, it used the filename it
comes up with, which while nice for youtube videos, is not right for
other files.
This means more work is done for urls that youtube-dl does support,
but is probably more efficient for other urls, since it only downloads
the first chunk of content, while youtube-dl probably downloads more.
This commit was supported by the NSF-funded DataLad project.
Diffstat (limited to 'doc')
2 files changed, 14 insertions, 0 deletions
diff --git a/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls/comment_2_1cebe1385d2b8a244afc259a78f72ada._comment b/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls/comment_2_1cebe1385d2b8a244afc259a78f72ada._comment new file mode 100644 index 000000000..624d094fd --- /dev/null +++ b/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls/comment_2_1cebe1385d2b8a244afc259a78f72ada._comment @@ -0,0 +1,6 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2017-12-06T16:02:55Z" + content=""" +"""]] diff --git a/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls/comment_4_f05e1047c5d22dddba21a9faa3397f0d._comment b/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls/comment_4_f05e1047c5d22dddba21a9faa3397f0d._comment new file mode 100644 index 000000000..b2aec7da1 --- /dev/null +++ b/doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls/comment_4_f05e1047c5d22dddba21a9faa3397f0d._comment @@ -0,0 +1,8 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 4""" + date="2017-12-08T18:48:46Z" + content=""" +That one happened with `git annex addurl --fast $url` so a different code +path. Had to add a html page check to youtubeDlFileName to fix it. +"""]] |