aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs/git-annex_unused_--from_s3_doesn__39__t
diff options
context:
space:
mode:
authorGravatar Joey Hess <joeyh@joeyh.name>2015-07-06 14:09:24 -0400
committerGravatar Joey Hess <joeyh@joeyh.name>2015-07-06 14:09:54 -0400
commit2ea34c47dd9819111f3cbaa2ce848581d286c05c (patch)
treeb3cc25b3b1c4e8d591394fa0d14817d4cae4424b /doc/bugs/git-annex_unused_--from_s3_doesn__39__t
parent83d0d7b74894be4ef8a655478deb106177839b1c (diff)
bugfix: Pass --full-tree when using git ls-files to get a list of files on the git-annex branch, so it works when run in a subdirectory. This bug affected git-annex unused, and potentially also transitions running code and other things.
Diffstat (limited to 'doc/bugs/git-annex_unused_--from_s3_doesn__39__t')
-rw-r--r--doc/bugs/git-annex_unused_--from_s3_doesn__39__t/comment_4_768cc5be3d9b53a45419d02f2cb25ec6._comment16
1 files changed, 16 insertions, 0 deletions
diff --git a/doc/bugs/git-annex_unused_--from_s3_doesn__39__t/comment_4_768cc5be3d9b53a45419d02f2cb25ec6._comment b/doc/bugs/git-annex_unused_--from_s3_doesn__39__t/comment_4_768cc5be3d9b53a45419d02f2cb25ec6._comment
new file mode 100644
index 000000000..7a09095e0
--- /dev/null
+++ b/doc/bugs/git-annex_unused_--from_s3_doesn__39__t/comment_4_768cc5be3d9b53a45419d02f2cb25ec6._comment
@@ -0,0 +1,16 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 4"""
+ date="2015-07-06T18:00:53Z"
+ content="""
+Analysis: To find the keys, it's using git ls-tree git-annex. When this is
+run in a subdirectory, it only lists files in the branch located under that
+subdirectory. Which is no files. It should pass --full-tree to avoid that
+problem.
+
+Pretty much everywhere git-annex uses ls-tree, it does pass --full-tree.
+But not in this particular case. Anything using Annex.Branch.branchFiles or
+Annex.Branch.files would be affected; that's limited to git-annex unused
+and code that runs transitions. git-annex unused w/o --from could also be
+affected, I think, perhaps it's harder to trigger that though.
+"""]]