aboutsummaryrefslogtreecommitdiff
path: root/doc/bugs/Windows_file_timestamp_timezone_madness.mdwn
diff options
context:
space:
mode:
authorGravatar Joey Hess <joey@kitenet.net>2014-06-12 13:43:16 -0400
committerGravatar Joey Hess <joey@kitenet.net>2014-06-12 13:54:08 -0400
commit624a9aba5adf8df8f0d9583454bf808842c3e15c (patch)
tree1cfbed8db158ad1e2d9b902cd8082f14a2e13fd9 /doc/bugs/Windows_file_timestamp_timezone_madness.mdwn
parent34c9eab951a73f06de70170cc2c2d40ce490ea70 (diff)
finish fixing windows timezone madness
Rather than calculating the TSDelta once, and caching it, this now reads the inode sential file's InodeCache file once, and then each time a new InodeCache is generated, looks at the sentinal file to get the current delta. This way, if the time zone changes while git-annex is running, it will adapt. This adds some inneffiency, but only on Windows, and only 1 stat per new file added. The worst innefficiency is that `git annex status` and `git annex sync` will now (on Windows) stat the inode sentinal file once per file in the repo. It would be more efficient to use getCurrentTimeZone, rather than needing to stat the sentinal file. This should be easy to do, once the time package gets my bugfix patch. This commit was sponsored by Jürgen Lüters.
Diffstat (limited to 'doc/bugs/Windows_file_timestamp_timezone_madness.mdwn')
-rw-r--r--doc/bugs/Windows_file_timestamp_timezone_madness.mdwn3
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/bugs/Windows_file_timestamp_timezone_madness.mdwn b/doc/bugs/Windows_file_timestamp_timezone_madness.mdwn
index a90c58f24..fb0b08d9d 100644
--- a/doc/bugs/Windows_file_timestamp_timezone_madness.mdwn
+++ b/doc/bugs/Windows_file_timestamp_timezone_madness.mdwn
@@ -14,3 +14,6 @@ Unfortunately, Data.Time.LocalTime.getCurrentTimeZone doesn't seem to really
work on windows. It always returns a time zone 60 minutes from UTS in my tests,
no matter what the zone really is. I need to test this more widely and file
a GHC bug if appropriate.
+
+> [[fixed|done]], avoiding using getCurrentTime for now, although I have a
+> patch to fix it too. --[[Joey]]