aboutsummaryrefslogtreecommitdiff
path: root/Creds.hs
diff options
context:
space:
mode:
authorGravatar Joey Hess <joey@kitenet.net>2014-09-18 19:03:15 -0400
committerGravatar Joey Hess <joey@kitenet.net>2014-09-18 19:03:15 -0400
commit0d2191dbea26c30f9d5ebbdca5aa130ba2b261cc (patch)
treeeb961c9b30f554b96e33d3f062cb851f99fb4562 /Creds.hs
parent78bef2bbb873fa41de277092d9c897fa8d6ee923 (diff)
error, don't warn about insecure creds
A one-time warning was not good enough. A hard error will force the user to notice the problem. Perhaps worth noting that git-annex enableremote already failed with an error, and nobody reported a bug. Suggests that not many people have used the insecure configuration, or if they did, they went to the bother to embedcreds, but never re-enabled the special remote.
Diffstat (limited to 'Creds.hs')
-rw-r--r--Creds.hs2
1 files changed, 1 insertions, 1 deletions
diff --git a/Creds.hs b/Creds.hs
index f9b8c4ec6..5e6c54ecc 100644
--- a/Creds.hs
+++ b/Creds.hs
@@ -110,7 +110,7 @@ getRemoteCredPair c storage = maybe fromcache (return . Just) =<< fromenv
-- Not a problem for shared cipher.
case storablecipher of
SharedCipher {} -> showLongNote "gpg error above was caused by an old git-annex bug in credentials storage. Working around it.."
- _ -> warning "*** Insecure credentials storage detected for this remote! See https://git-annex.branchable.com/upgrades/insecure_embedded_creds/"
+ _ -> error "*** Insecure credentials storage detected for this remote! See https://git-annex.branchable.com/upgrades/insecure_embedded_creds/"
fromcreds $ fromB64 enccreds
fromcreds creds = case decodeCredPair creds of
Just credpair -> do