diff options
| author |  Joey Hess <joeyh@joeyh.name> | 2015-10-04 15:26:20 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2015-10-04 15:26:20 -0400 |
| commit | 5d4f334ad27ce3518e8a5f964f432225fa8f043b (patch) | |
| tree | afba79609649554c17169eca20efacab63b03841 | |
| parent | bab757768982e8681b40cc4db909ef73881f3182 (diff) | |
review
| -rw-r--r-- | doc/bugs/Utility__47__libdiskfree.c_more_BSD_friendly/comment_2_54bfedf6d33bcd9d44cc3c89f3216161._comment | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/doc/bugs/Utility__47__libdiskfree.c_more_BSD_friendly/comment_2_54bfedf6d33bcd9d44cc3c89f3216161._comment b/doc/bugs/Utility__47__libdiskfree.c_more_BSD_friendly/comment_2_54bfedf6d33bcd9d44cc3c89f3216161._comment new file mode 100644 index 000000000..b86fa0535 --- /dev/null +++ b/doc/bugs/Utility__47__libdiskfree.c_more_BSD_friendly/comment_2_54bfedf6d33bcd9d44cc3c89f3216161._comment @@ -0,0 +1,23 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2015-10-04T19:13:59Z" + content=""" +Happy to support all BSD varients that tested patches can be made for. + +I can't apply this patch as-is for several reasons: + +* You say you've not tested it yet. +* I recently modified the file to add support for Solaris, and your patch conflicts with that modification. +* Your patch in passing changes the FreeBSD support to use the + statfs64 structure. AFAIK that has not been tested. +* I think you also broke Android by moving it below the Linux tests. + The linux tests will probably fire on android, but the linux code + doesn't work with the android libc. + +Your patch would be better if it clearly added support for an OS +(or standard) without touching and breaking existing code that +supports other OSes. + +Thanks! +"""]] |