aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Joey Hess <joey@kitenet.net>2011-04-21 11:06:29 -0400
committerGravatar Joey Hess <joey@kitenet.net>2011-04-21 11:06:29 -0400
commit2467c567713321b061c3daf92df39d4e35226c7b (patch)
tree38ea4f75a533d32e1f0a74648ee3940f3dbb8315
parent45bdb2d4136f2faf61a3fde63477ad5d935583b1 (diff)
update on S3 memory leaks
The remaining leaks are in hS3. The leak with encryption was worked around by the use of the temp file. (And was probably originally caused by gpgCipherHandle sparking a thread which kept a reference to the start of the byte string.)
-rw-r--r--debian/changelog3
-rw-r--r--doc/bugs/S3_memory_leaks.mdwn15
2 files changed, 4 insertions, 14 deletions
diff --git a/debian/changelog b/debian/changelog
index 30a3e7cc5..7b0bdd103 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,8 +3,7 @@ git-annex (0.20110420) UNRELEASED; urgency=low
* Update Debian build dependencies for ghc 7.
* Debian package is now built with S3 support.
Thanks Joachim Breitner for making this possible.
- * No longer needs to buffer entire files when sending them to S3.
- (However, getting files from S3 still requires buffering.)
+ * Somewhat improved memory usage of S3, still work to do.
Thanks Greg Heartsfield for ongoing work to improve the hS3 library
for git-annex.
diff --git a/doc/bugs/S3_memory_leaks.mdwn b/doc/bugs/S3_memory_leaks.mdwn
index bfb3e1ec5..d8b10b075 100644
--- a/doc/bugs/S3_memory_leaks.mdwn
+++ b/doc/bugs/S3_memory_leaks.mdwn
@@ -1,17 +1,8 @@
S3 has memory leaks
-## with encryption
+Sending a file to S3 causes a slow memory increase toward the file size.
-One only occurs with encryption. It was was fixed for bup, but
-not yet for S3, in 5985acdfad8a6791f0b2fc54a1e116cee9c12479.
-(The fix I used for bup doesn't seem to work with S3.)
-
-## always
-
-Copying the file back from S3 causes a slow memory increase toward 119 mb.
+Copying the file back from S3 causes a slow memory increase toward the
+file size.
The author of hS3 is aware of the problem, and working on it.
-
-## fixed
-
-memory leak while uploading content to S3