| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
| |
And re-run IWYU, adjust #includes.
|
| |
|
|
|
| |
Enable build setting to allow Xcode to complain about invalid
comments.
|
| |
|
|
|
|
|
| |
Cygwin still doesn't support any of the backtrace functions. Also, remove a
spurious newline from a debug message.
Fixes #2993
|
| |
|
|
|
|
|
|
|
|
| |
This change does several things. First, and most important, it allows
dumping the "n" most recent stack frames on each debug() call. Second,
it demangles the C++ symbols. Third, it prepends each debug() message
with the debug level.
Unrelated to the above I've replaced all `assert(!is_forked_child());`
statements with `ASSERT_IS_NOT_FORKED_CHILD()` for consistency.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's currently too easy for someone to bork their shell by doing something
like `function test; return 0; end`. That's obviously a silly, contrived,
example but the point is that novice users who learn about functions are
prone to do something like that without realizing it will bork the shell. Even
expert users who know about the `test` builtin might forget that, say, `pwd`
is a builtin.
This change adds a `--shadow-builtin` flag that must be specified to
indicate you know what you're doing.
Fixes #3000
|
| |
|
|
|
|
|
|
| |
The fork (create new process) related debugging messages rely on an
undocumented env var and use `printf()` rather than `debug()`. There are
also errors in how the fork count is tracked that this fixes.
Fixes #2995
|
| |
|
|
|
| |
This removes some pointless parentheses but the primary focus is removing
redundancies like unnecessary "else" clauses.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I missed restyling a few "switch" blocks to make them consistent with the rest
of the code base. This fixes that oversight. This should be the final step in
restyling the C++ code to have a consistent style. This also includes a few
trivial cleanups elsewhere.
I also missed restyling the "complete" module when working my way from a to z
so this final change includes restyling that module.
Total lint errors decreased 36%. Cppcheck errors went from 47 to 24. Oclint P2
errors went from 819 to 778. Oclint P3 errors went from 3252 to 1842.
Resolves #2902.
|
| |
|
|
|
|
| |
Reduces lint errors from 121 to 59 (-51%). Line count from 1578 to 1290 (-18%).
Another step in resolving issue #2902.
|
| |
|
|
|
|
|
|
|
| |
Remove the "make iwyu" build target. Move the functionality into the
recently introduced lint.fish script. Fix a lot, but not all, of the
include-what-you-use errors. Specifically, it fixes all of the IWYU errors
on my OS X server but only removes some of them on my Ubuntu 14.04 server.
Fixes #2957
|
| | |
|
| |
|
|
|
|
|
|
|
| |
When replacing the existing fish process with a new process it is
important to restore the temrinal modes to what they were when fish
started running. We don't want any tweaks done for the benefit of fish
(e.g., disabling ICRNL mode) to bleed thru to an "exec"ed command.
Resolves #2609
|
| |
|
|
|
|
|
| |
If stdio is dead due to EPIPE, there's no great reason to spew a stack dump.
This will still write an error to stderr if stdout dies. This might be
undesirable, but changing that should be considered separately.
|
| |
|
|
|
|
|
| |
This fixes building on platforms such as Android
which lacks <spawn.h>.
Signed-off-by: David Adam <zanchey@ucc.gu.uwa.edu.au>
|
| |
|
|
|
| |
Allows cases like `string split \n < file.txt` to work.
Fixes 2422
|
| |
|
|
|
|
|
| |
This change eliminates global variables like stdout_buffer. Instead we wrap up
the IO information into a new struct io_streams_t, and thread that through
every builtin. This makes the intent clearer, gives us a place to hang new IO
data, and eliminates the ugly global state management like builtin_push_io.
|
| | |
|
| | |
|
|
|
This change moves source files into a src/ directory,
and puts object files into an obj/ directory. The Makefile
and xcode project are updated accordingly.
Fixes #1866
|
Aaron Gyes
Kurtis Rader
ridiculousfish
Andy Lutomirski
Fredrik Fornwall
David Adam